[Home]

Summary:ASTERISK-13644: [patch] MEETME_RECORDINGFILE is not read by MeetMe()
Reporter:Daniel C (dalbaech)Labels:
Date Opened:2009-02-24 18:39:13.000-0600Date Closed:2009-03-03 16:25:24.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme-realtime.patch
( 1) app_meetme-realtime3.patch
( 2) app_meetme-realtime4.patch
( 3) app_meetme-realtime5.patch
( 4) Realtime_Conference_Record_workaround.txt
Description:The MEETME_RECORDINGFILE variable is not pulled into MeetMe when it is declared.
Asterisk SVN-trunk-r178446.

Declaration and call:
MYSQL(Query resultid ${connid} SELECT `record`,`unique`,`recordingfilename` from asterisk.meetme where `confno`=${EXTEN:1} AND `starttime` <= "${CallTime}" AND `endtime` >= "${CallTime}";);
MYSQL(Fetch fetchid ${resultid} record unique recordingfilename);
MYSQL(Clear ${resultid});
MYSQL(Disconnect ${connid});
MEETME_RECORDINGFILE="${recordingfilename}";
       NoOp(File: ${MEETME_RECORDINGFILE});
MeetMe(${EXTEN:1},rMcCs,);

NoOp shows the proper path, but it still attempts to write to /var/spool/asterisk/meetme...
Comments:By: David Vossel (dvossel) 2009-02-26 14:27:59.000-0600

I couldn't reproduce your results. Here's how I tested it.   I used the latest rev from trunk as well as the rev you reported.

exten => 0987,1,Set(GLOBAL(MEETME_RECORDINGFILE)=/usr/src/tests/v.wav)
exten => 0987,n,NoOp(File: ${MEETME_RECORDINGFILE})
exten => 0987,n,MeetMe(0987,rMcCs,0987)
By: Daniel C (dalbaech) 2009-02-26 19:19:00.000-0600

After further troubleshooting, this only happens if the conference is realtime.

If it loads from the database with the call:
MeetMe({EXTEN:1},rMcCs,); it doesn't read the MEETME_RECORDINGFILE variable...
If it's called with:
MeetMe({EXTEN:1},rMcCsd,); it works.

This is strange behavior.
By: Daniel C (dalbaech) 2009-02-26 21:26:52.000-0600

Ok...

Actually, I went ahead and made a patch for this.

The values were coded into the realtime function that prevented the global. However, if someone wants to use realtime, why not set this in the DB???

So...

I added two fields to my table asterisk.meetme:
`recordingfilename` varchar(20) NOT NULL
`recordingformat` varchar(4) NOT NULL
By: Daniel C (dalbaech) 2009-02-27 12:44:55.000-0600

I actually fixed the problem rather than work around it by just declaring it in the database.

In app_meetme-realtime3.patch:
The channel variables are pulled in if the database variable isn't there.
If there's a database variable, it gets precedence.

I've tested with Dynamic and RealTime conferences, haven't tested on a normal one made in a config file.
By: David Vossel (dvossel) 2009-02-27 15:32:14.000-0600

I've made a few changes to the patch.  most of which just involved cleaning up some areas.  Would you be able to run a sanity check on it using your realtime setup for me?
By: Daniel C (dalbaech) 2009-02-27 16:26:33.000-0600

Quick testing shows that it looks good. Took the default if the database was empty.

Also accepted channel variable when declared and database empty.
By: Digium Subversion (svnbot) 2009-03-03 16:01:25.000-0600

Repository: asterisk
Revision: 179972

U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r179972 | dvossel | 2009-03-03 16:01:25 -0600 (Tue, 03 Mar 2009) | 13 lines

app_meetme not setting filename and fileformat correctly for realtime

When app_meetme finds a realtime conference, it doesn't get the filename and fileformat correctly when 'r' is set.  Now app_meetme first checks to see if fileformat and filename are declared in the db, if they're not it checks the .conf file, if its not declared there either it then uses defaults.

(closes issue ASTERISK-13644)
Reported by: dalbaech
Patches:
app_meetme-realtime5.patch uploaded by dvossel (license 671)
Realtime_Conference_Record_workaround.txt uploaded by dalbaech (license 705)
Tested by: dvossel, dalbaech
Review: http://reviewboard.digium.com/r/180/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=179972
By: Digium Subversion (svnbot) 2009-03-03 16:23:24.000-0600

Repository: asterisk
Revision: 179995

_U  branches/1.6.1/

------------------------------------------------------------------------
r179995 | dvossel | 2009-03-03 16:23:24 -0600 (Tue, 03 Mar 2009) | 18 lines

Blocked revisions 179972 via svnmerge

........
 r179972 | dvossel | 2009-03-03 16:01:24 -0600 (Tue, 03 Mar 2009) | 13 lines
 
 app_meetme not setting filename and fileformat correctly for realtime
 
 When app_meetme finds a realtime conference, it doesn't get the filename and fileformat correctly when 'r' is set.  Now app_meetme first checks to see if fileformat and filename are declared in the db, if they're not it checks the .conf file, if its not declared there either it then uses defaults.
 
 (closes issue ASTERISK-13644)
 Reported by: dalbaech
 Patches:
  app_meetme-realtime5.patch uploaded by dvossel (license 671)
  Realtime_Conference_Record_workaround.txt uploaded by dalbaech (license 705)
 Tested by: dvossel, dalbaech
 Review: http://reviewboard.digium.com/r/180/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=179995
By: Digium Subversion (svnbot) 2009-03-03 16:25:24.000-0600

Repository: asterisk
Revision: 180005

_U  branches/1.6.0/

------------------------------------------------------------------------
r180005 | dvossel | 2009-03-03 16:25:24 -0600 (Tue, 03 Mar 2009) | 18 lines

Blocked revisions 179972 via svnmerge

........
 r179972 | dvossel | 2009-03-03 16:01:24 -0600 (Tue, 03 Mar 2009) | 13 lines
 
 app_meetme not setting filename and fileformat correctly for realtime
 
 When app_meetme finds a realtime conference, it doesn't get the filename and fileformat correctly when 'r' is set.  Now app_meetme first checks to see if fileformat and filename are declared in the db, if they're not it checks the .conf file, if its not declared there either it then uses defaults.
 
 (closes issue ASTERISK-13644)
 Reported by: dalbaech
 Patches:
  app_meetme-realtime5.patch uploaded by dvossel (license 671)
  Realtime_Conference_Record_workaround.txt uploaded by dalbaech (license 705)
 Tested by: dvossel, dalbaech
 Review: http://reviewboard.digium.com/r/180/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=180005