[Home]

Summary:ASTERISK-13631: iLBC transcoding times are always zero
Reporter:pj (pj)Labels:
Date Opened:2009-02-23 13:37:23.000-0600Date Closed:2009-03-12 13:07:52
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Codecs/codec_ilbc
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090311__bug14532.diff.txt
( 1) show-translation.png
Description:"core show translation" always shows "zero" times of transcoding,
I'm using iLBC downloaded using script contrib/scripts/get_ilbc_source.sh
and built without using external ilbc-devel system libraries.
except this issue, iLBC codec is working fine.




****** ADDITIONAL INFORMATION ******

cat /proc/cpuinfo
processor       : 0
vendor_id       : GenuineIntel
cpu family      : 6
model           : 6
model name      : Mobile Pentium II
stepping        : 10
cpu MHz         : 298.627
cache size      : 256 KB
fdiv_bug        : no
hlt_bug         : no
f00f_bug        : no
coma_bug        : no
fpu             : yes
fpu_exception   : yes
cpuid level     : 2
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 sep mtrr pge mca cmov pat pse36 mmx fxsr up
Comments:By: pj (pj) 2009-02-23 13:58:36.000-0600

It seems, that it's somehow specific to cpu type or cpu clock speed, because asterisk on another server with different cpu (that have higher cpu clock) doesn't have this issue.
If you look at the attached table, weird is, that times for some relationships like ilbc vs. alaw/ulaw/slin are displayed, other are zero...
By: pj (pj) 2009-03-11 13:00:47

one hint: can't be this issue caused by reason, that translation matrix shows only values up to 99999 and values above this limit are displayed as 'zero'?
By: Tilghman Lesher (tilghman) 2009-03-11 16:31:10

This patch should fix it for you.  I made the width completely dynamic, then tested it under valgrind, which makes most of the codecs take a six-digit time.
By: Tilghman Lesher (tilghman) 2009-03-11 16:31:59

<pre>*CLI> core show translation
        Translation times between formats (in microseconds) for one second of data
         Source Format (Rows) Destination Format (Columns)

          g723    gsm   ulaw   alaw g726aal2  adpcm   slin  lpc10  g729  speex   ilbc   g726   g722 siren7 siren14 slin16
    g723     -      -      -      -        -      -      -      -     -      -      -      -      -      -       -      -
     gsm     -      -  92006  92006   188012 104007  88006 344021     - 544035 796050 192012 168011      -       - 300019
    ulaw     - 184011      -   4000   108006  24001   8000 264015     - 464029 716044 112006  88005      -       - 220013
    alaw     - 180011   4001      -   104006  20001   4000 260015     - 460029 712044 108006  84005      -       - 216013
g726aal2     - 252016  80005  80005        -  92006  76005 332020     - 532034 784049   4000 156010      -       - 288018
   adpcm     - 188012  16001  16001   112007      -  12001 268016     - 468030 720045 116007  92006      -       - 224014
    slin     - 176011   4000   4000   100006  16001      - 256015     - 456029 708044 104006  80005      -       - 212013
   lpc10     - 320020 148009 148009   244015 160010 144009      -     - 600038 852053 248015 224014      -       - 356022
    g729     -      -      -      -        -      -      -      -     -      -      -      -      -      -       -      -
   speex     - 388025 216014 216014   312020 228015 212014 468029     -      - 920058 316020 292019      -       - 424027
    ilbc     - 396025 224014 224014   320020 236015 220014 476029     - 676043      - 324020 300019      -       - 432027
    g726     - 252017  80006  80006        1  92007  76006 332021     - 532035 784050      - 156011      -       - 288019
    g722     - 332021 160010 160010   256016 172011 156010 412025     - 612039 864054 260016      -      -       - 132008
  siren7     -      -      -      -        -      -      -      -     -      -      -      -      -      -       -      -
 siren14     -      -      -      -        -      -      -      -     -      -      -      -      -      -       -      -
  slin16     - 460029 288018 288018   384024 300019 284018 540033     - 740047 992062 388024 128008      -       -      -
</pre>
By: pj (pj) 2009-03-12 02:25:11

your patch resolved issue with displaying values above 99999 in translation matrix, thanks!
By: Digium Subversion (svnbot) 2009-03-12 12:32:14

Repository: asterisk
Revision: 181731

U   trunk/main/translate.c

------------------------------------------------------------------------
r181731 | tilghman | 2009-03-12 12:32:14 -0500 (Thu, 12 Mar 2009) | 9 lines

Adjust translation table column widths based upon the translation times.
Previously, only 5 columns were displayed, and if a translation time exceeded
99,999 useconds, it would be displayed as 0, instead of its actual time.
(closes issue ASTERISK-13631)
Reported by: pj
Patches:
      20090311__bug14532.diff.txt uploaded by tilghman (license 14)
Tested by: pj

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=181731
By: Digium Subversion (svnbot) 2009-03-12 12:58:26

Repository: asterisk
Revision: 181732

_U  branches/1.6.0/
U   branches/1.6.0/configure
U   branches/1.6.0/main/translate.c

------------------------------------------------------------------------
r181732 | tilghman | 2009-03-12 12:58:26 -0500 (Thu, 12 Mar 2009) | 16 lines

Merged revisions 181731 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r181731 | tilghman | 2009-03-12 12:32:13 -0500 (Thu, 12 Mar 2009) | 9 lines
 
 Adjust translation table column widths based upon the translation times.
 Previously, only 5 columns were displayed, and if a translation time exceeded
 99,999 useconds, it would be displayed as 0, instead of its actual time.
 (closes issue ASTERISK-13631)
  Reported by: pj
  Patches:
        20090311__bug14532.diff.txt uploaded by tilghman (license 14)
  Tested by: pj
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=181732
By: Digium Subversion (svnbot) 2009-03-12 13:07:52

Repository: asterisk
Revision: 181733

_U  branches/1.6.1/
U   branches/1.6.1/main/translate.c

------------------------------------------------------------------------
r181733 | tilghman | 2009-03-12 13:07:52 -0500 (Thu, 12 Mar 2009) | 16 lines

Merged revisions 181731 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r181731 | tilghman | 2009-03-12 12:32:13 -0500 (Thu, 12 Mar 2009) | 9 lines
 
 Adjust translation table column widths based upon the translation times.
 Previously, only 5 columns were displayed, and if a translation time exceeded
 99,999 useconds, it would be displayed as 0, instead of its actual time.
 (closes issue ASTERISK-13631)
  Reported by: pj
  Patches:
        20090311__bug14532.diff.txt uploaded by tilghman (license 14)
  Tested by: pj
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=181733