Summary: | ASTERISK-13630: MWI subscriptions does not works if there is no HINT for extension | ||
Reporter: | Martin Vit (festr) | Labels: | |
Date Opened: | 2009-02-23 09:44:31.000-0600 | Date Closed: | 2009-02-24 09:22:31.000-0600 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/Subscriptions |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | in chan_sip.c: inside function handle_request_subscribe there is "gotdest = get_destination(p, NULL)" which is searching for hints and if does not find any it will end. But if SUBSCRIBE event is "message-summary" for voicemail checking (MWI), it will never reach this code if there is no hints defined (for mwi there is no need to define any hint). This leads to non working MWI at all. I've tried commenting out check for gotdest to proove that mwi is working without defined hints. But I dont how to make proper patch :) ****** ADDITIONAL INFORMATION ****** I'm using sip/voicemail realtime | ||
Comments: | By: Digium Subversion (svnbot) 2009-02-24 09:16:08.000-0600 Repository: asterisk Revision: 178205 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r178205 | file | 2009-02-24 09:16:07 -0600 (Tue, 24 Feb 2009) | 9 lines Skip check for extension when subscribing for MWI. Since the remote side is not actually subscribing to a specific extension when subscribing for MWI just skip the check to see if the extension exists. They can't use it to specify the mailbox either since we require configuration of that in sip.conf (closes issue ASTERISK-13630) Reported by: festr ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=178205 By: Digium Subversion (svnbot) 2009-02-24 09:18:44.000-0600 Repository: asterisk Revision: 178213 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r178213 | file | 2009-02-24 09:18:43 -0600 (Tue, 24 Feb 2009) | 16 lines Merged revisions 178205 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r178205 | file | 2009-02-24 11:16:07 -0400 (Tue, 24 Feb 2009) | 9 lines Skip check for extension when subscribing for MWI. Since the remote side is not actually subscribing to a specific extension when subscribing for MWI just skip the check to see if the extension exists. They can't use it to specify the mailbox either since we require configuration of that in sip.conf (closes issue ASTERISK-13630) Reported by: festr ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=178213 By: Digium Subversion (svnbot) 2009-02-24 09:20:55.000-0600 Repository: asterisk Revision: 178224 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r178224 | file | 2009-02-24 09:20:55 -0600 (Tue, 24 Feb 2009) | 23 lines Merged revisions 178213 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r178213 | file | 2009-02-24 11:18:38 -0400 (Tue, 24 Feb 2009) | 16 lines Merged revisions 178205 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r178205 | file | 2009-02-24 11:16:07 -0400 (Tue, 24 Feb 2009) | 9 lines Skip check for extension when subscribing for MWI. Since the remote side is not actually subscribing to a specific extension when subscribing for MWI just skip the check to see if the extension exists. They can't use it to specify the mailbox either since we require configuration of that in sip.conf (closes issue ASTERISK-13630) Reported by: festr ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=178224 By: Digium Subversion (svnbot) 2009-02-24 09:22:30.000-0600 Repository: asterisk Revision: 178232 _U branches/1.6.1/ U branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r178232 | file | 2009-02-24 09:22:30 -0600 (Tue, 24 Feb 2009) | 23 lines Merged revisions 178213 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r178213 | file | 2009-02-24 11:18:38 -0400 (Tue, 24 Feb 2009) | 16 lines Merged revisions 178205 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r178205 | file | 2009-02-24 11:16:07 -0400 (Tue, 24 Feb 2009) | 9 lines Skip check for extension when subscribing for MWI. Since the remote side is not actually subscribing to a specific extension when subscribing for MWI just skip the check to see if the extension exists. They can't use it to specify the mailbox either since we require configuration of that in sip.conf (closes issue ASTERISK-13630) Reported by: festr ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=178232 |