Summary:ASTERISK-13604: [patch] Addition of DAHDI application to call libpri functions for MWI via ISDN/CISC.
Reporter:Jeremy S (jeremy1)Labels:patch
Date Opened:2009-02-18 16:18:35.000-0600Date Closed:2018-01-02 08:49:51.000-0600
Versions:Frequency of
Environment:Attachments:( 0) chan_dahdi.c-14501.txt
( 1) chan_dahdi.c-174042.txt
( 2) chan_dahdi.c-174042-2.txt
Description:Many will find useful an open application which invokes libpri's pri_mwi_activate and pri_mwi_deactivate functions.

Patch attached.

I know next to nothing about C so here are some things that I hope others will help cleanup:

1. Asterisk attempts to hang up channels which wouldn't happen since this is a CISC. Example output:
[Feb 18 15:06:55] WARNING[12069]: chan_dahdi.c:11336 pri_dchannel: Hangup requested on unconfigured channel 0/0 span 1
[Feb 18 15:06:56] WARNING[12069]: chan_dahdi.c:10285 pri_fixup_principle: Call specified, but not found?
[Feb 18 15:06:56] WARNING[12069]: chan_dahdi.c:11463 pri_dchannel: Hangup REQ on bad channel 0/3 on span 1

2. The activate and de-activate functions should be wrapped into one with a passed variable making the case difference.


[patch removed]
Comments:By: Jason Parker (jparker) 2009-02-18 16:25:46.000-0600

Patches must be attached, rather than added as part of the description or a comment.

By: Jason Parker (jparker) 2009-02-18 16:52:44.000-0600

You deleted your note, but your concern is very valid (about personal information being sent in cleartext for the license agreement).  We're looking into options.  Stay tuned.

By: Jeremy S (jeremy1) 2009-02-18 16:55:14.000-0600

Thank you. I will gladly sign the agreement when it's safe to do so.

By: Jason Parker (jparker) 2009-02-19 14:58:20.000-0600

bugs.digium.com is now available over https. :)

If you have any issues with that, it would be greatly appreciated if you could open another bug for those issues.  You should be able to safely submit a license agreement now though.

By: Jeremy S (jeremy1) 2009-02-19 19:26:58.000-0600

I have accepted the license and it is in pending state. Should I re-attach the patch once the license is accepted by Digium?

By: Jeremy S (jeremy1) 2009-02-24 17:19:06.000-0600

New patch against chan_dahdi.c version 174042 attached.

By: Jeremy S (jeremy1) 2009-05-04 16:26:58

bugs.digium.com is no longer accessible via https.

Attaching a corrected diff to chan_dahdi.c version 174042.

By: Corey Farrell (coreyfarrell) 2017-12-14 13:37:21.805-0600

Are you interested in pursuing this further?  If so the patch will need to be rebased so it can apply the the current {{master}} branch and it will need to go through code review.


Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review \[1\] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines \[2\]
* Review the Code Review Checklist \[3\] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch \[4\]

When ready, submit your patch and any tests to Gerrit \[5\] for code review.


\[1\] https://wiki.asterisk.org/wiki/display/AST/Code+Review
\[2\] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
\[3\] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
\[4\] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
\[5\] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

By: Asterisk Team (asteriskteam) 2018-01-02 08:49:51.393-0600

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines