| Summary: | ASTERISK-13577: [patch] Crash in VoiceMailMain if hangup occurs before a valid mailbox number is entered (IMAP only) | ||
| Reporter: | Douglas Paul (dwpaul) | Labels: | |
| Date Opened: | 2009-02-12 19:24:18.000-0600 | Date Closed: | 2009-02-13 13:52:05.000-0600 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_voicemail/IMAP |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) voicemail_imap_crash_no_mailbox.patch | |
| Description: | (this actually is for version 1.4.23.1) If VoiceMailMain() is called from a dialplan without a valid mailbox number or with no mailbox number, the user is prompted for a mailbox number. If they then hangup before entering a number, Asterisk will crash. This only occurs with the IMAP store. ****** ADDITIONAL INFORMATION ****** The crash occurs when copying the context from vmu to vms, though if no valid mailbox has been entered, vmu is a NULL pointer. So, I just added a check to make sure vmu isn't NULL. | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-02-13 07:51:36.000-0600 Thanks for the patch dwpaul! I look forward to your license getting approved. By: Leif Madsen (lmadsen) 2009-02-13 13:12:56.000-0600 License acknowledged! By: Digium Subversion (svnbot) 2009-02-13 13:47:49.000-0600 Repository: asterisk Revision: 175590 U branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r175590 | mmichelson | 2009-02-13 13:47:49 -0600 (Fri, 13 Feb 2009) | 16 lines Fix a potential crash situation when using IMAP voicemail If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue ASTERISK-13577) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=175590 By: Digium Subversion (svnbot) 2009-02-13 13:49:39.000-0600 Repository: asterisk Revision: 175591 _U trunk/ U trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r175591 | mmichelson | 2009-02-13 13:49:39 -0600 (Fri, 13 Feb 2009) | 22 lines Merged revisions 175590 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r175590 | mmichelson | 2009-02-13 13:47:48 -0600 (Fri, 13 Feb 2009) | 16 lines Fix a potential crash situation when using IMAP voicemail If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue ASTERISK-13577) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=175591 By: Digium Subversion (svnbot) 2009-02-13 13:51:26.000-0600 Repository: asterisk Revision: 175592 _U branches/1.6.0/ ------------------------------------------------------------------------ r175592 | mmichelson | 2009-02-13 13:51:26 -0600 (Fri, 13 Feb 2009) | 28 lines Blocked revisions 175591 via svnmerge ................ r175591 | mmichelson | 2009-02-13 13:49:38 -0600 (Fri, 13 Feb 2009) | 22 lines Merged revisions 175590 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r175590 | mmichelson | 2009-02-13 13:47:48 -0600 (Fri, 13 Feb 2009) | 16 lines Fix a potential crash situation when using IMAP voicemail If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue ASTERISK-13577) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=175592 By: Digium Subversion (svnbot) 2009-02-13 13:52:04.000-0600 Repository: asterisk Revision: 175593 _U branches/1.6.1/ U branches/1.6.1/apps/app_voicemail.c ------------------------------------------------------------------------ r175593 | mmichelson | 2009-02-13 13:52:04 -0600 (Fri, 13 Feb 2009) | 29 lines Merged revisions 175591 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r175591 | mmichelson | 2009-02-13 13:49:38 -0600 (Fri, 13 Feb 2009) | 22 lines Merged revisions 175590 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r175590 | mmichelson | 2009-02-13 13:47:48 -0600 (Fri, 13 Feb 2009) | 16 lines Fix a potential crash situation when using IMAP voicemail If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue ASTERISK-13577) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=175593 | ||