[Home]

Summary:ASTERISK-13555: in "_sip_tcp_helper_thread" Buffer is filled with dirty bytes
Reporter:umberto amorevoli (umberto71)Labels:
Date Opened:2009-02-10 10:36:22.000-0600Date Closed:2009-06-26 15:50:22
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/TCP-TLS
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I've seen with aastra phones 51i and 57i that buffer "buf" is not empty with TLS.
I suggest to do this patch
.....
for (;;) {
memset(req.data, 0, sizeof(req.data));
memset(buf, 0, sizeof(buf));  //<<<<<<<<<<<<<<<<<<< Patch
req.len = 0;
req.ignore = 0;
req.debug = 0;
.....

****** ADDITIONAL INFORMATION ******

I see that sdp is filled with bad data, i found this buffer can be not empty with TLS. May be there is an error in TLS....
Comments:By: Kristijan Vrban (vrban) 2009-04-17 16:16:14

hello, i have seen something like that with a softphone (PhonerLite) where the TCP buffer always was filled with a blank line. Because the softphone broadcast empty SIP dummy packages as NAT opener.

This was very annoying, because the dummy SIP packag contents only a single "\r\n", with the effect, that a real SIP messages was getting this extra blank line from the dummy package because it was still in the buffer, and so the get_header function was not capable to work proper. I my case this was the reason the return value for the Content-Length was always 0.

Perhaps you have the same issue with the aastra phones?
By: Digium Subversion (svnbot) 2009-06-26 15:47:41

Repository: asterisk
Revision: 203779

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r203779 | russell | 2009-06-26 15:47:41 -0500 (Fri, 26 Jun 2009) | 5 lines

Ensure the TCP read buffer is fully initialized before handling each packet.

(closes issue ASTERISK-13555)
Reported by: umberto71

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203779
By: Digium Subversion (svnbot) 2009-06-26 15:48:29

Repository: asterisk
Revision: 203780

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r203780 | russell | 2009-06-26 15:48:29 -0500 (Fri, 26 Jun 2009) | 12 lines

Merged revisions 203779 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r203779 | russell | 2009-06-26 15:45:00 -0500 (Fri, 26 Jun 2009) | 5 lines
 
 Ensure the TCP read buffer is fully initialized before handling each packet.
 
 (closes issue ASTERISK-13555)
 Reported by: umberto71
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203780
By: Digium Subversion (svnbot) 2009-06-26 15:48:32

Repository: asterisk
Revision: 203781

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r203781 | russell | 2009-06-26 15:48:32 -0500 (Fri, 26 Jun 2009) | 12 lines

Merged revisions 203779 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r203779 | russell | 2009-06-26 15:45:00 -0500 (Fri, 26 Jun 2009) | 5 lines
 
 Ensure the TCP read buffer is fully initialized before handling each packet.
 
 (closes issue ASTERISK-13555)
 Reported by: umberto71
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203781
By: Digium Subversion (svnbot) 2009-06-26 15:50:21

Repository: asterisk
Revision: 203782

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r203782 | russell | 2009-06-26 15:50:21 -0500 (Fri, 26 Jun 2009) | 12 lines

Merged revisions 203779 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r203779 | russell | 2009-06-26 15:45:00 -0500 (Fri, 26 Jun 2009) | 5 lines
 
 Ensure the TCP read buffer is fully initialized before handling each packet.
 
 (closes issue ASTERISK-13555)
 Reported by: umberto71
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203782