Summary:	ASTERISK-13527: [patch] Asterisk must not perform SRV lookups if a port is specified in the URI
Reporter:	klaus3000 (klaus3000)	Labels:
Date Opened:	2009-02-06 04:15:24.000-0600	Date Closed:	2009-08-20 14:21:57
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Interoperability
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) patch_chan_sip_nosrvifport_1.4.23.txt
Description:	Asterisk must not perform SRV lookups if a port is specified in the URI (see RFC 3263 for details)
Comments:	By: Mark Michelson (mmichelson) 2009-02-09 10:16:51.000-0600 Thanks for the patch. I have confirmed that this is correct based on the RFC you mentioned, and the patch looks good to me. I'll probably expand the comment you added to indicate that we don't do an SRV lookup due to the text in section 4.2 of RFC 3263. That way the comment explains a bit better why it is that we don't do an SRV lookup when a port is specified. By: Digium Subversion (svnbot) 2009-02-09 11:11:07.000-0600 Repository: asterisk Revision: 174282 U   branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r174282 | mmichelson | 2009-02-09 11:11:07 -0600 (Mon, 09 Feb 2009) | 12 lines Don't do an SRV lookup if a port is specified RFC 3263 says to do A record lookups on a hostname if a port has been specified, so that's what we're going to do. See section 4.2. (closes issue ASTERISK-13527) Reported by: klaus3000 Patches:      patch_chan_sip_nosrvifport_1.4.23.txt uploaded by klaus3000 (license 65) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=174282 By: Digium Subversion (svnbot) 2009-02-09 11:21:09.000-0600 Repository: asterisk Revision: 174301 _U  trunk/ U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r174301 | mmichelson | 2009-02-09 11:21:08 -0600 (Mon, 09 Feb 2009) | 20 lines Merged revisions 174282 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r174282 | mmichelson | 2009-02-09 11:11:05 -0600 (Mon, 09 Feb 2009) | 12 lines Don't do an SRV lookup if a port is specified RFC 3263 says to do A record lookups on a hostname if a port has been specified, so that's what we're going to do. See section 4.2. (closes issue ASTERISK-13527) Reported by: klaus3000 Patches:      patch_chan_sip_nosrvifport_1.4.23.txt uploaded by klaus3000 (license 65) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=174301 By: Digium Subversion (svnbot) 2009-02-09 11:25:21.000-0600 Repository: asterisk Revision: 174322 _U  branches/1.6.0/ U   branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r174322 | mmichelson | 2009-02-09 11:25:21 -0600 (Mon, 09 Feb 2009) | 28 lines Merged revisions 174301 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r174301 | mmichelson | 2009-02-09 11:20:55 -0600 (Mon, 09 Feb 2009) | 20 lines Merged revisions 174282 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r174282 | mmichelson | 2009-02-09 11:11:05 -0600 (Mon, 09 Feb 2009) | 12 lines Don't do an SRV lookup if a port is specified RFC 3263 says to do A record lookups on a hostname if a port has been specified, so that's what we're going to do. See section 4.2. (closes issue ASTERISK-13527) Reported by: klaus3000 Patches:      patch_chan_sip_nosrvifport_1.4.23.txt uploaded by klaus3000 (license 65) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=174322 By: Digium Subversion (svnbot) 2009-02-09 11:26:39.000-0600 Repository: asterisk Revision: 174326 _U  branches/1.6.1/ U   branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r174326 | mmichelson | 2009-02-09 11:26:39 -0600 (Mon, 09 Feb 2009) | 28 lines Merged revisions 174301 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r174301 | mmichelson | 2009-02-09 11:20:55 -0600 (Mon, 09 Feb 2009) | 20 lines Merged revisions 174282 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r174282 | mmichelson | 2009-02-09 11:11:05 -0600 (Mon, 09 Feb 2009) | 12 lines Don't do an SRV lookup if a port is specified RFC 3263 says to do A record lookups on a hostname if a port has been specified, so that's what we're going to do. See section 4.2. (closes issue ASTERISK-13527) Reported by: klaus3000 Patches:      patch_chan_sip_nosrvifport_1.4.23.txt uploaded by klaus3000 (license 65) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=174326