[Home]

Summary:ASTERISK-13494: priexclusive parameter ignored if pri = pri_cpe ?
Reporter:Matteo Brancaleoni (mbrancaleoni)Labels:
Date Opened:2009-02-02 04:16:48.000-0600Date Closed:2009-06-26 20:24:39
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Hi,

there's a special reason why the priexclusive param is used only if the pri is pri_net ?

Looking to this snippet of code (both in chan_zap and chan_dahdi):

**************************
               /* Add support for exclusive override */
               if (p->priexclusive)
                       exclusive = 1;
               else {
               /* otherwise, traditional behavior */
                       if (p->pri->nodetype == PRI_NETWORK)
                               exclusive = 0;
                       else
                               exclusive = 1;
               }
**************************

Seems that the exclusive is always true if the pri is PRI_CPE ?
There's a special reason for that?

Many telcos requires that the channel selection on CPE side must NOT be exclusive...

I don't know if there's some drawback into setting exclusive = 0 even when PRI_CPE is selected.
Comments:By: Leif Madsen (lmadsen) 2009-02-26 17:35:00.000-0600

I reassigned this issue to jpeeler because russell thought it might be fun for you :)
By: Jeff Peeler (jpeeler) 2009-03-04 22:39:05.000-0600

It's possible that I'm misreading the code, but it looks like the channel selection on the CPE side is set to be non-exclusive. This setting occurs in q931_setup in libpri. I'm not confident about this though. Will have to do some testing.
By: Matteo Brancaleoni (mbrancaleoni) 2009-03-05 09:08:03.000-0600

no, the code always set exclusive, except for pri_net conf.
I've checked also with pri debug and q931 SETUP message cleary states " exclusive " channel selection.
By: Digium Subversion (svnbot) 2009-06-26 19:55:13

Repository: asterisk
Revision: 203908

U   branches/1.4/channels/chan_dahdi.c

------------------------------------------------------------------------
r203908 | rmudgett | 2009-06-26 19:55:12 -0500 (Fri, 26 Jun 2009) | 16 lines

The ISDN CPE side should not exclusively pick B channels normally.

Before this patch, Asterisk unconditionally picked B channels exclusively
on the CPE side and normally allowed alternative B channels on the network
side.  Now Asterisk does the opposite.

Reasons for the CPE side to normally not pick B channels exclusively:
*  For CPE point-to-multipoint mode (i.e. phone side), the CPE side does
not have enough information to exclusively pick B channels.  (There may be
other devices on the line.)
*  Q.931 gives preference to the network side picking B channels.
*  Some telcos require the CPE side to not pick B channels exclusively.

(closes issue ASTERISK-13494)
Reported by: mbrancaleoni

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203908
By: Digium Subversion (svnbot) 2009-06-26 20:07:53

Repository: asterisk
Revision: 203909

_U  trunk/
U   trunk/channels/sig_pri.c

------------------------------------------------------------------------
r203909 | rmudgett | 2009-06-26 20:07:53 -0500 (Fri, 26 Jun 2009) | 23 lines

Merged revisions 203908 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r203908 | rmudgett | 2009-06-26 19:55:12 -0500 (Fri, 26 Jun 2009) | 16 lines
 
 The ISDN CPE side should not exclusively pick B channels normally.
 
 Before this patch, Asterisk unconditionally picked B channels exclusively
 on the CPE side and normally allowed alternative B channels on the network
 side.  Now Asterisk does the opposite.
 
 Reasons for the CPE side to normally not pick B channels exclusively:
 *  For CPE point-to-multipoint mode (i.e. phone side), the CPE side does
 not have enough information to exclusively pick B channels.  (There may be
 other devices on the line.)
 *  Q.931 gives preference to the network side picking B channels.
 *  Some telcos require the CPE side to not pick B channels exclusively.
 
 (closes issue ASTERISK-13494)
 Reported by: mbrancaleoni
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203909
By: Digium Subversion (svnbot) 2009-06-26 20:14:18

Repository: asterisk
Revision: 203910

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_dahdi.c

------------------------------------------------------------------------
r203910 | rmudgett | 2009-06-26 20:14:18 -0500 (Fri, 26 Jun 2009) | 30 lines

Merged revisions 203909 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r203909 | rmudgett | 2009-06-26 20:07:52 -0500 (Fri, 26 Jun 2009) | 23 lines
 
 Merged revisions 203908 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r203908 | rmudgett | 2009-06-26 19:55:12 -0500 (Fri, 26 Jun 2009) | 16 lines
   
   The ISDN CPE side should not exclusively pick B channels normally.
   
   Before this patch, Asterisk unconditionally picked B channels exclusively
   on the CPE side and normally allowed alternative B channels on the network
   side.  Now Asterisk does the opposite.
   
   Reasons for the CPE side to normally not pick B channels exclusively:
   *  For CPE point-to-multipoint mode (i.e. phone side), the CPE side does
   not have enough information to exclusively pick B channels.  (There may be
   other devices on the line.)
   *  Q.931 gives preference to the network side picking B channels.
   *  Some telcos require the CPE side to not pick B channels exclusively.
   
   (closes issue ASTERISK-13494)
   Reported by: mbrancaleoni
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203910
By: Digium Subversion (svnbot) 2009-06-26 20:18:49

Repository: asterisk
Revision: 203918

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_dahdi.c

------------------------------------------------------------------------
r203918 | rmudgett | 2009-06-26 20:18:49 -0500 (Fri, 26 Jun 2009) | 30 lines

Merged revisions 203909 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r203909 | rmudgett | 2009-06-26 20:07:52 -0500 (Fri, 26 Jun 2009) | 23 lines
 
 Merged revisions 203908 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r203908 | rmudgett | 2009-06-26 19:55:12 -0500 (Fri, 26 Jun 2009) | 16 lines
   
   The ISDN CPE side should not exclusively pick B channels normally.
   
   Before this patch, Asterisk unconditionally picked B channels exclusively
   on the CPE side and normally allowed alternative B channels on the network
   side.  Now Asterisk does the opposite.
   
   Reasons for the CPE side to normally not pick B channels exclusively:
   *  For CPE point-to-multipoint mode (i.e. phone side), the CPE side does
   not have enough information to exclusively pick B channels.  (There may be
   other devices on the line.)
   *  Q.931 gives preference to the network side picking B channels.
   *  Some telcos require the CPE side to not pick B channels exclusively.
   
   (closes issue ASTERISK-13494)
   Reported by: mbrancaleoni
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203918
By: Digium Subversion (svnbot) 2009-06-26 20:24:38

Repository: asterisk
Revision: 203941

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_dahdi.c

------------------------------------------------------------------------
r203941 | rmudgett | 2009-06-26 20:24:38 -0500 (Fri, 26 Jun 2009) | 30 lines

Merged revisions 203909 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r203909 | rmudgett | 2009-06-26 20:07:52 -0500 (Fri, 26 Jun 2009) | 23 lines
 
 Merged revisions 203908 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r203908 | rmudgett | 2009-06-26 19:55:12 -0500 (Fri, 26 Jun 2009) | 16 lines
   
   The ISDN CPE side should not exclusively pick B channels normally.
   
   Before this patch, Asterisk unconditionally picked B channels exclusively
   on the CPE side and normally allowed alternative B channels on the network
   side.  Now Asterisk does the opposite.
   
   Reasons for the CPE side to normally not pick B channels exclusively:
   *  For CPE point-to-multipoint mode (i.e. phone side), the CPE side does
   not have enough information to exclusively pick B channels.  (There may be
   other devices on the line.)
   *  Q.931 gives preference to the network side picking B channels.
   *  Some telcos require the CPE side to not pick B channels exclusively.
   
   (closes issue ASTERISK-13494)
   Reported by: mbrancaleoni
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203941