Summary:	ASTERISK-13480: [patch] Add audio announce option to app_page.c
Reporter:	Daniel Ferrer (dferrer)	Labels:
Date Opened:	2009-01-29 09:21:21.000-0600	Date Closed:	2011-05-04 13:57:03
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) page_announce.patch
Description:	It adds an extra option 'A(x)' to app_page (similar to Dial 'A(x)'), to playback an announce simultaneously in all paged phones and (caller's one) before conference bridge is activated. Something like this: exten => **,1,SIPAddHeader(Alert-Info: Ring Answer) exten => **,n,Page(SIP/100&SIP/101,qA(chime)) where 'chime' is an audio file with a typical "airport" announce. There's also another option 'n' that makes only to play announce in all paged phones and not to play in caller's phone. If this was not specified the announce were played simultaneously in SIP phone 100, 101 and in caller's headset. This is tipically used with Polycom phones, passing a SIP header that makes the paged phones to autoanswer the call in hands-free speaker. To acomplish this task, the only way that I found is to modify also app_meetme, adding an option for play an arbitrary announce at start of conference (G(x) option). The patch works for trunk, I also have a patch for 1.4.23. ****** ADDITIONAL INFORMATION ****** Adding an option to app_meetme.c was a problem in trunk, because app_meetme.c already had 31 flag options, to add flag number 32 I could change flag register to 64 bit (like app_dial.c), and use ast_test_flag64. Fortunately I found that position "21" was free, so I decide to use that bit flag position for the new option, so I didn't do any 32->64 bit flag change.
Comments:	By: Tilghman Lesher (tilghman) 2009-02-20 16:22:45.000-0600 I'd recommend posting this patch on http://reviewboard.digium.com By: Daniel Ferrer (dferrer) 2009-03-05 12:48:48.000-0600 http://reviewboard.digium.com/r/188/ By: Digium Subversion (svnbot) 2009-12-10 11:31:24.000-0600 Repository: asterisk Revision: 234173 U   trunk/CHANGES U   trunk/apps/app_meetme.c U   trunk/apps/app_page.c U   trunk/main/app.c ------------------------------------------------------------------------ r234173 | jpeeler | 2009-12-10 11:31:24 -0600 (Thu, 10 Dec 2009) | 20 lines Add audio announcement option to app_page As described in the CHANGES file: * MeetMe has a new option 'G' to play an announcement before joining a  conference. * Page has a new option 'A(x)' which will playback an announcement  simultaneously to all paged phones (and optionally excluding the caller's one  using the new option 'n') before the call is bridged. To add the new option to meetme, the conference flag options had to be extended to 64 bits. (closes issue ASTERISK-13480) Reported by: dferrer Patches:      page_announce.patch uploaded by dferrer (license 525)      modified by me Review: https://reviewboard.asterisk.org/r/188/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=234173 By: Digium Subversion (svnbot) 2011-05-04 13:51:42 Repository: asterisk Revision: 316831 U   branches/1.8/apps/app_meetme.c ------------------------------------------------------------------------ r316831 | rmudgett | 2011-05-04 13:51:41 -0500 (Wed, 04 May 2011) | 9 lines Wait for leader with Music On Hold allows crosstalk between participants. Parenthesis in the wrong position.  Regression from issue ASTERISK-13480 when expanding conference flags to use 64 bits. (closes issue ASTERISK-17061) Reported by: MrHanMan Tested by: rmudgett ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=316831 By: Digium Subversion (svnbot) 2011-05-04 13:57:03 Repository: asterisk Revision: 316832 _U  trunk/ U   trunk/apps/app_meetme.c ------------------------------------------------------------------------ r316832 | rmudgett | 2011-05-04 13:57:03 -0500 (Wed, 04 May 2011) | 16 lines Merged revisions 316831 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........  r316831 | rmudgett | 2011-05-04 13:51:40 -0500 (Wed, 04 May 2011) | 9 lines    Wait for leader with Music On Hold allows crosstalk between participants.    Parenthesis in the wrong position.  Regression from issue ASTERISK-13480 when  expanding conference flags to use 64 bits.    (closes issue ASTERISK-17061)  Reported by: MrHanMan  Tested by: rmudgett ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=316832