| Summary: | ASTERISK-13465: [patch] Asterisk does not detect an attended transfer if the 'Replaces=' option is not at the beginning of the query string | ||
| Reporter: | fhackenberger (fhackenberger) | Labels: | |
| Date Opened: | 2009-01-27 17:31:13.000-0600 | Date Closed: | 2009-02-06 11:23:03.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Transfers |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) attended_transfer_header_fix | |
| Description: | Asterisk does not detect an attended transfer if the 'Replaces=' option is not at the beginning of the query string of the Refer-To header. Example: Refer-To: <sip:6001@hacki-mobile:5060?Require=replaces&Replaces=9ccf51d5-349c-4064-9428-b4c94cb73ece%3Bto-tag%3Das2578745e%3Bfrom-tag%3Dd8e9bba0-a205-40f6-b8bf-daaddc6557ce> Result: Asterisk does not detect an attended transfer (wrong) Refer-To: <sip:6001@hacki-mobile:5060?Replaces=9ccf51d5-349c-4064-9428-b4c94cb73ece%3Bto-tag%3Das2578745e%3Bfrom-tag%3Dd8e9bba0-a205-40f6-b8bf-daaddc6557ce> Result: Asterisk does detect an attended transfer ****** ADDITIONAL INFORMATION ****** Applies to 1.6.1 as well. | ||
| Comments: | By: fhackenberger (fhackenberger) 2009-01-27 17:36:35.000-0600 Fixed by the attached patch. Tested with pjsip 1.0, which sends the header in the first example above. By: Digium Subversion (svnbot) 2009-02-06 11:14:16.000-0600 Repository: asterisk Revision: 173967 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r173967 | file | 2009-02-06 11:14:15 -0600 (Fri, 06 Feb 2009) | 4 lines Some clients do not put the call-id for replaces at the beginning, so support it being anywhere in the string. (closes issue ASTERISK-13465) Reported by: fhackenberger ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173967 By: Digium Subversion (svnbot) 2009-02-06 11:18:39.000-0600 Repository: asterisk Revision: 173974 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r173974 | file | 2009-02-06 11:18:39 -0600 (Fri, 06 Feb 2009) | 15 lines Merged revisions 173967-173968 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173967 | file | 2009-02-06 13:14:15 -0400 (Fri, 06 Feb 2009) | 4 lines Some clients do not put the call-id for replaces at the beginning, so support it being anywhere in the string. (closes issue ASTERISK-13465) Reported by: fhackenberger ........ r173968 | file | 2009-02-06 13:15:01 -0400 (Fri, 06 Feb 2009) | 2 lines Remove a debug message I put in by accident. ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173974 By: Digium Subversion (svnbot) 2009-02-06 11:21:09.000-0600 Repository: asterisk Revision: 173986 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r173986 | file | 2009-02-06 11:21:09 -0600 (Fri, 06 Feb 2009) | 22 lines Merged revisions 173974 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r173974 | file | 2009-02-06 13:18:35 -0400 (Fri, 06 Feb 2009) | 15 lines Merged revisions 173967-173968 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173967 | file | 2009-02-06 13:14:15 -0400 (Fri, 06 Feb 2009) | 4 lines Some clients do not put the call-id for replaces at the beginning, so support it being anywhere in the string. (closes issue ASTERISK-13465) Reported by: fhackenberger ........ r173968 | file | 2009-02-06 13:15:01 -0400 (Fri, 06 Feb 2009) | 2 lines Remove a debug message I put in by accident. ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173986 By: Digium Subversion (svnbot) 2009-02-06 11:23:02.000-0600 Repository: asterisk Revision: 173994 _U branches/1.6.1/ U branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r173994 | file | 2009-02-06 11:23:02 -0600 (Fri, 06 Feb 2009) | 22 lines Merged revisions 173974 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r173974 | file | 2009-02-06 13:18:35 -0400 (Fri, 06 Feb 2009) | 15 lines Merged revisions 173967-173968 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173967 | file | 2009-02-06 13:14:15 -0400 (Fri, 06 Feb 2009) | 4 lines Some clients do not put the call-id for replaces at the beginning, so support it being anywhere in the string. (closes issue ASTERISK-13465) Reported by: fhackenberger ........ r173968 | file | 2009-02-06 13:15:01 -0400 (Fri, 06 Feb 2009) | 2 lines Remove a debug message I put in by accident. ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173994 | ||