[Home]

Summary:ASTERISK-13460: [patch] Outbound proxy not used for registrations
Reporter:nick_lewis (nick_lewis)Labels:
Date Opened:2009-01-27 05:15:11.000-0600Date Closed:2009-08-07 09:33:23
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Registration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) callbackextension_peer_trunk.diff
Description:If callbackextension is defined for a peer it successfully causes a registration to occur but the registration ignores the outboundproxy settings for the peer
Comments:By: nick_lewis (nick_lewis) 2009-01-27 06:17:23.000-0600

The obproxy_get() function that is called during registration really needs to be passed a peer so that peer specific obproxies can be used during registration. The problem at the moment is that the registration string (whether directly from sip.conf registration string or generated by a peer with callbackextension) does not contain a peername field. For a number of reasons this needs to be added. It could be something like:

register=peername?transport://user@domain:authuser:secret@host:port/callback~expiry

This would also allow other parameters omitted from the registration string to be taken directly from the peer definition
By: Olle Johansson (oej) 2009-01-29 07:31:35.000-0600

Arrgghh. This needs to be fixed too.
By: David Vossel (dvossel) 2009-06-25 13:28:12

the patch I uploaded adds the [peername?] option allowing for the peer's outbound proxy to be found
By: Digium Subversion (svnbot) 2009-07-10 16:42:11

Repository: asterisk
Revision: 205985

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r205985 | dvossel | 2009-07-10 16:42:11 -0500 (Fri, 10 Jul 2009) | 16 lines

SIP register not using peer's outbound proxy

If callbackextension is defined for a peer it successfully causes
a registration to occur, but the registration ignores the
outboundproxy settings for the peer.  This patch allows the
peer to be passed to obproxy_get() in transmit_register().

(closes issue ASTERISK-13460)
Reported by: Nick_Lewis
Patches:
     callbackextension_peer_trunk.diff uploaded by dvossel (license 671)
Tested by: dvossel

Review: https://reviewboard.asterisk.org/r/294/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=205985
By: Digium Subversion (svnbot) 2009-07-10 16:46:38

Repository: asterisk
Revision: 205986

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r205986 | dvossel | 2009-07-10 16:46:38 -0500 (Fri, 10 Jul 2009) | 22 lines

Merged revisions 205985 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r205985 | dvossel | 2009-07-10 16:42:10 -0500 (Fri, 10 Jul 2009) | 16 lines
 
 SIP register not using peer's outbound proxy
 
 If callbackextension is defined for a peer it successfully causes
 a registration to occur, but the registration ignores the
 outboundproxy settings for the peer.  This patch allows the
 peer to be passed to obproxy_get() in transmit_register().
 
 (closes issue ASTERISK-13460)
 Reported by: Nick_Lewis
 Patches:
       callbackextension_peer_trunk.diff uploaded by dvossel (license 671)
 Tested by: dvossel
 
 Review: https://reviewboard.asterisk.org/r/294/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=205986
By: Digium Subversion (svnbot) 2009-07-10 16:52:30

Repository: asterisk
Revision: 205987

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r205987 | dvossel | 2009-07-10 16:52:30 -0500 (Fri, 10 Jul 2009) | 22 lines

Merged revisions 205985 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r205985 | dvossel | 2009-07-10 16:42:10 -0500 (Fri, 10 Jul 2009) | 16 lines
 
 SIP register not using peer's outbound proxy
 
 If callbackextension is defined for a peer it successfully causes
 a registration to occur, but the registration ignores the
 outboundproxy settings for the peer.  This patch allows the
 peer to be passed to obproxy_get() in transmit_register().
 
 (closes issue ASTERISK-13460)
 Reported by: Nick_Lewis
 Patches:
       callbackextension_peer_trunk.diff uploaded by dvossel (license 671)
 Tested by: dvossel
 
 Review: https://reviewboard.asterisk.org/r/294/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=205987
By: Digium Subversion (svnbot) 2009-07-10 17:50:52

Repository: asterisk
Revision: 206017

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r206017 | dvossel | 2009-07-10 17:50:52 -0500 (Fri, 10 Jul 2009) | 22 lines

Merged revisions 205985 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r205985 | dvossel | 2009-07-10 16:42:10 -0500 (Fri, 10 Jul 2009) | 16 lines
 
 SIP register not using peer's outbound proxy
 
 If callbackextension is defined for a peer it successfully causes
 a registration to occur, but the registration ignores the
 outboundproxy settings for the peer.  This patch allows the
 peer to be passed to obproxy_get() in transmit_register().
 
 (closes issue ASTERISK-13460)
 Reported by: Nick_Lewis
 Patches:
       callbackextension_peer_trunk.diff uploaded by dvossel (license 671)
 Tested by: dvossel
 
 Review: https://reviewboard.asterisk.org/r/294/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=206017