| Summary: | ASTERISK-13454: set_member_paused ignores return-value from update_realtime_member_field | ||
| Reporter: | Fredrik Liljegren (fiddur) | Labels: | |
| Date Opened: | 2009-01-27 02:02:22.000-0600 | Date Closed: | 2009-03-01 16:07:11.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 14338.patch | |
| Description: | In app_queue.c, update_realtime_member_field returns a value indicating success or failure, but when it is called from set_member_paused, the return value is ignored. In my case, I think that's why it doesn't bark when it failes to pause a queue_member with autopause. The logs just states that the member is paused automatically, but no changes are made to the queue_member_table. ****** ADDITIONAL INFORMATION ****** The error occured since the tables created from realtime_pgsql.sql doesn't add any uniqueid to queue_member_table. It would be nice to get at least a debug log entry that says where the error is :) I'm posting a separate bug for updating contrib/scripts/realtime_pgsql.sql | ||
| Comments: | By: Mark Michelson (mmichelson) 2009-02-12 11:15:16.000-0600 Given that other bugs you have filed have been against 1.6.0, I am assuming that version is also where you are experiencing this. I grabbed some of the code that already existed in trunk in set_member_paused and transplanted it into 1.6.0. I've uploaded the patch as 14338.patch. Let me know if you think this is sufficient. Thanks! By: Fredrik Liljegren (fiddur) 2009-02-26 07:00:02.000-0600 Yep, that's great. Thank's. By: Digium Subversion (svnbot) 2009-03-01 16:07:10.000-0600 Repository: asterisk Revision: 179222 U branches/1.6.0/apps/app_queue.c ------------------------------------------------------------------------ r179222 | mmichelson | 2009-03-01 16:07:10 -0600 (Sun, 01 Mar 2009) | 13 lines Add error checking when updating the "paused" field of a realtime queue member. This code already existed in trunk and 1.6.1, but was not in 1.6.0 prior to this commit. (closes issue ASTERISK-13454) Reported by: fiddur Patches: 14338.patch uploaded by mmichelson (license 60) Tested by: fiddur ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=179222 | ||