[Home]

Summary:ASTERISK-13440: [patch] i18n.testsuite.conf in contribs directory uses old dialplan format an has no Chinese test
Reporter:dant (dant)Labels:
Date Opened:2009-01-23 01:27:41.000-0600Date Closed:2009-01-23 14:25:22.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) i18n.testsuite.conf.issue14320.diff
( 1) i18n.testsuite.conf.issue14320.v2.diff
Description:i18n.testsuite.conf in the contribs directory uses
Wait,1 rather than Wait(1)
SetLanguage(?) rather than Set(CHANNEL(language)=?)
all steps numbered

In addition, there is a lack of a test for Chinese numbering
Comments:By: dant (dant) 2009-01-23 01:37:43.000-0600

(Note: the first patch, without v2 in the name, should be removed due to bad diff options, sorry)

Patch updates i18n.testsuite.conf (in contribs) with the following:
All instances of Wait,1 replaced with Wait(1)
All instances of SetLanguage(?) replaced with Set(CHANNEL(language)=?)
Only first step is numbered as 1, subsequent steps numbered with 'n'
Chinese tests added at extension 851 with comments giving expected results in pinyin

By: Mark Michelson (mmichelson) 2009-01-23 14:19:16.000-0600

Thanks for the patch. I will get this committed ASAP

By: Digium Subversion (svnbot) 2009-01-23 14:21:28.000-0600

Repository: asterisk
Revision: 170671

U   branches/1.4/contrib/i18n.testsuite.conf

------------------------------------------------------------------------
r170671 | mmichelson | 2009-01-23 14:21:27 -0600 (Fri, 23 Jan 2009) | 14 lines

Update contrib/i18n.testsuite.conf to not use deprecated syntax

* Convert Wait,1 to Wait(1)
* Convert SetLanguage to Set(CHANNEL(language))
* Use 'n' for all priorities beyond the first

Also added test for Chinese numbers, too.

(closes issue ASTERISK-13440)
Reported by: dant
Patches:
     i18n.testsuite.conf.issue14320.v2.diff uploaded by dant (license 670)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=170671

By: Digium Subversion (svnbot) 2009-01-23 14:22:36.000-0600

Repository: asterisk
Revision: 170677

_U  trunk/
U   trunk/contrib/i18n.testsuite.conf

------------------------------------------------------------------------
r170677 | mmichelson | 2009-01-23 14:22:36 -0600 (Fri, 23 Jan 2009) | 22 lines

Merged revisions 170671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170671 | mmichelson | 2009-01-23 14:21:51 -0600 (Fri, 23 Jan 2009) | 14 lines

Update contrib/i18n.testsuite.conf to not use deprecated syntax

* Convert Wait,1 to Wait(1)
* Convert SetLanguage to Set(CHANNEL(language))
* Use 'n' for all priorities beyond the first

Also added test for Chinese numbers, too.

(closes issue ASTERISK-13440)
Reported by: dant
Patches:
     i18n.testsuite.conf.issue14320.v2.diff uploaded by dant (license 670)


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=170677

By: Digium Subversion (svnbot) 2009-01-23 14:23:55.000-0600

Repository: asterisk
Revision: 170685

_U  branches/1.6.0/
U   branches/1.6.0/contrib/i18n.testsuite.conf

------------------------------------------------------------------------
r170685 | mmichelson | 2009-01-23 14:23:55 -0600 (Fri, 23 Jan 2009) | 30 lines

Merged revisions 170677 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r170677 | mmichelson | 2009-01-23 14:23:00 -0600 (Fri, 23 Jan 2009) | 22 lines

Merged revisions 170671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170671 | mmichelson | 2009-01-23 14:21:51 -0600 (Fri, 23 Jan 2009) | 14 lines

Update contrib/i18n.testsuite.conf to not use deprecated syntax

* Convert Wait,1 to Wait(1)
* Convert SetLanguage to Set(CHANNEL(language))
* Use 'n' for all priorities beyond the first

Also added test for Chinese numbers, too.

(closes issue ASTERISK-13440)
Reported by: dant
Patches:
     i18n.testsuite.conf.issue14320.v2.diff uploaded by dant (license 670)


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=170685

By: Digium Subversion (svnbot) 2009-01-23 14:25:22.000-0600

Repository: asterisk
Revision: 170693

_U  branches/1.6.1/
U   branches/1.6.1/contrib/i18n.testsuite.conf

------------------------------------------------------------------------
r170693 | mmichelson | 2009-01-23 14:25:21 -0600 (Fri, 23 Jan 2009) | 30 lines

Merged revisions 170677 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r170677 | mmichelson | 2009-01-23 14:23:00 -0600 (Fri, 23 Jan 2009) | 22 lines

Merged revisions 170671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170671 | mmichelson | 2009-01-23 14:21:51 -0600 (Fri, 23 Jan 2009) | 14 lines

Update contrib/i18n.testsuite.conf to not use deprecated syntax

* Convert Wait,1 to Wait(1)
* Convert SetLanguage to Set(CHANNEL(language))
* Use 'n' for all priorities beyond the first

Also added test for Chinese numbers, too.

(closes issue ASTERISK-13440)
Reported by: dant
Patches:
     i18n.testsuite.conf.issue14320.v2.diff uploaded by dant (license 670)


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=170693