[Home]

Summary:ASTERISK-13437: [patch] Latest cdr_addon_mysql queries borked
Reporter:Hugh Messenger (cheesegrits)Labels:
Date Opened:2009-01-22 20:40:34.000-0600Date Closed:2009-01-26 17:34:03.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Addons/cdr_mysql
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_mysql.diff
Description:After updating to the latest asterisk-addons SVN, my MySQL log queries are broken:

[Jan 22 19:55:17] DEBUG[8359] cdr_addon_mysql.c: SQL command as follows: INSERT INTO cdr (calldate,clid,src,dst,dcontext,channel,dstchannel,lastapp,lastdata,duration,billsec,disposition,amaflags,,uniqueid,) VALUES ('2009-01-22 19:55:13','\"Hugh Poly\" <301>','301','300','from-internal','SIP/301-0a2304a8','SIP/300-0a387ba0','Dial','SIP/300,,tr','4','2','ANSWERED','3',,'1232675713.0',')

Note the missing fields / values (coresponding to userfield and accountcode) and the extra ' on the end of values.

I'll attempt to attach a diff for the changes I had to make to get it working.
Comments:By: Digium Subversion (svnbot) 2009-01-26 17:32:04.000-0600

Repository: asterisk-addons
Revision: 749

U   trunk/cdr/cdr_addon_mysql.c

------------------------------------------------------------------------
r749 | tilghman | 2009-01-26 17:32:04 -0600 (Mon, 26 Jan 2009) | 6 lines

When fields are missing, the resulting SQL is wrong.
(closes issue ASTERISK-13437)
Reported by: cheesegrits
Patches:
      cdr_mysql.diff uploaded by cheesegrits (license 672)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=749
By: Digium Subversion (svnbot) 2009-01-26 17:34:02.000-0600

Repository: asterisk-addons
Revision: 750

_U  branches/1.6.1/

------------------------------------------------------------------------
r750 | tilghman | 2009-01-26 17:34:02 -0600 (Mon, 26 Jan 2009) | 12 lines

Blocked revisions 749 via svnmerge

........
 r749 | tilghman | 2009-01-26 17:32:42 -0600 (Mon, 26 Jan 2009) | 6 lines
 
 When fields are missing, the resulting SQL is wrong.
 (closes issue ASTERISK-13437)
  Reported by: cheesegrits
  Patches:
        cdr_mysql.diff uploaded by cheesegrits (license 672)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=750