| Summary: | ASTERISK-13360: [patch] Log and debug messages in ast_rtp_destroy can cause a crash | ||
| Reporter: | John Covert (jcovert) | Labels: | |
| Date Opened: | 2009-01-13 17:43:55.000-0600 | Date Closed: | 2009-01-22 14:05:45.000-0600 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | Core/RTP |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) rtp.c.patch-1.6.0.3 ( 1) rtp.c.patch-svn-165599 | |
| Description: | It's possible for rtp->rtcp to be zero, in which case a reference to rtp->rtcp->whatever is not a good idea. When app_asr ("just digits") calls ast_rtp_destroy, a crash happens every time. Patch included fixes this. | ||
| Comments: | By: John Covert (jcovert) 2009-01-19 22:26:44.000-0600 Patch for trunk (svn 165599) also provided. By: Digium Subversion (svnbot) 2009-01-22 14:02:12.000-0600 Repository: asterisk Revision: 170239 U branches/1.4/main/rtp.c ------------------------------------------------------------------------ r170239 | file | 2009-01-22 14:02:12 -0600 (Thu, 22 Jan 2009) | 7 lines Don't crash if RTCP is not enabled on an RTP structure but statistics are output. (closes issue ASTERISK-13360) Reported by: jcovert Patches: rtp.c.patch-1.6.0.3 uploaded by jcovert (license 551) rtp.c.patch-svn-165599 uploaded by jcovert (license 551) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=170239 By: Digium Subversion (svnbot) 2009-01-22 14:04:16.000-0600 Repository: asterisk Revision: 170240 _U trunk/ U trunk/main/rtp.c ------------------------------------------------------------------------ r170240 | file | 2009-01-22 14:04:16 -0600 (Thu, 22 Jan 2009) | 14 lines Merged revisions 170239 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r170239 | file | 2009-01-22 16:02:35 -0400 (Thu, 22 Jan 2009) | 7 lines Don't crash if RTCP is not enabled on an RTP structure but statistics are output. (closes issue ASTERISK-13360) Reported by: jcovert Patches: rtp.c.patch-1.6.0.3 uploaded by jcovert (license 551) rtp.c.patch-svn-165599 uploaded by jcovert (license 551) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=170240 By: Digium Subversion (svnbot) 2009-01-22 14:05:01.000-0600 Repository: asterisk Revision: 170241 _U branches/1.6.0/ U branches/1.6.0/main/rtp.c ------------------------------------------------------------------------ r170241 | file | 2009-01-22 14:05:01 -0600 (Thu, 22 Jan 2009) | 21 lines Merged revisions 170240 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r170240 | file | 2009-01-22 16:04:39 -0400 (Thu, 22 Jan 2009) | 14 lines Merged revisions 170239 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r170239 | file | 2009-01-22 16:02:35 -0400 (Thu, 22 Jan 2009) | 7 lines Don't crash if RTCP is not enabled on an RTP structure but statistics are output. (closes issue ASTERISK-13360) Reported by: jcovert Patches: rtp.c.patch-1.6.0.3 uploaded by jcovert (license 551) rtp.c.patch-svn-165599 uploaded by jcovert (license 551) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=170241 By: Digium Subversion (svnbot) 2009-01-22 14:05:44.000-0600 Repository: asterisk Revision: 170242 _U branches/1.6.1/ U branches/1.6.1/main/rtp.c ------------------------------------------------------------------------ r170242 | file | 2009-01-22 14:05:44 -0600 (Thu, 22 Jan 2009) | 21 lines Merged revisions 170240 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r170240 | file | 2009-01-22 16:04:39 -0400 (Thu, 22 Jan 2009) | 14 lines Merged revisions 170239 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r170239 | file | 2009-01-22 16:02:35 -0400 (Thu, 22 Jan 2009) | 7 lines Don't crash if RTCP is not enabled on an RTP structure but statistics are output. (closes issue ASTERISK-13360) Reported by: jcovert Patches: rtp.c.patch-1.6.0.3 uploaded by jcovert (license 551) rtp.c.patch-svn-165599 uploaded by jcovert (license 551) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=170242 | ||