[Home]

Summary:ASTERISK-13359: port :0 added to SIP INVITE URI when 'outboundproxy' used in [general] section of sip.conf
Reporter:Chris Maciejewski (chris-mac)Labels:
Date Opened:2009-01-13 15:21:27.000-0600Date Closed:2009-01-16 18:32:55.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-bug14233.diff.txt
Description:How to reproduce:

extensions.conf:
exten => _X.,1,Dial(SIP/enum-test@sip.nemox.net,45)

without 'outboundproxy' set in sip.conf [general] INVITE (sent directly to final destination):
INVITE sip:enum-test@sip.nemox.net SIP/2.0
...

with 'outboundproxy' set INVITE (request sent via proxy):
INVITE sip:enum-test@sip.nemox.net:0 SIP/2.0
...

NOTE: port :0 appended to URI!!! - Maybe this is related to ASTERISK-13199 ?
Comments:By: James Golovich (jamesgolovich) 2009-01-13 22:45:36.000-0600

I was able to duplicate the issue and this patch resolves the issue.

Even though we aren't sending the packet direct to the host we need to parse out the port and include it in case the ultimate destination is on a non standard port.
By: Chris Maciejewski (chris-mac) 2009-01-14 01:17:07.000-0600

I can confirm patch attached resolved my issue :-)
By: Leif Madsen (lmadsen) 2009-01-14 17:58:19.000-0600

Assigned to otherwiseguy for review, and possible commit. Thanks!
By: Olle Johansson (oej) 2009-01-15 07:39:23.000-0600

Looks ok to me.
By: Terry Wilson (twilson) 2009-01-16 17:55:39.000-0600

Confirmed on 1.6.0, 1.6.1, and trunk.  1.4 is fine.  I'll get it committed and merged.
By: Digium Subversion (svnbot) 2009-01-16 18:03:38.000-0600

Repository: asterisk
Revision: 169044

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r169044 | twilson | 2009-01-16 18:03:37 -0600 (Fri, 16 Jan 2009) | 8 lines

Fix port :0 added to SIP INVITE URI when outboundproxy used

(closes issue ASTERISK-13359)
Reported by: chris-mac
Patches:
     asterisk-bug14233.diff.txt uploaded by jamesgolovich (license 176)
Tested by: jamesgolovich, chris-mac, otherwiseguy

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=169044
By: Digium Subversion (svnbot) 2009-01-16 18:30:06.000-0600

Repository: asterisk
Revision: 169078

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r169078 | twilson | 2009-01-16 18:30:06 -0600 (Fri, 16 Jan 2009) | 15 lines

Merged revisions 169044 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r169044 | twilson | 2009-01-16 18:03:39 -0600 (Fri, 16 Jan 2009) | 8 lines
 
 Fix port :0 added to SIP INVITE URI when outboundproxy used
 
 (closes issue ASTERISK-13359)
 Reported by: chris-mac
 Patches:
       asterisk-bug14233.diff.txt uploaded by jamesgolovich (license 176)
 Tested by: jamesgolovich, chris-mac, otherwiseguy
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=169078
By: Digium Subversion (svnbot) 2009-01-16 18:32:54.000-0600

Repository: asterisk
Revision: 169079

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r169079 | twilson | 2009-01-16 18:32:54 -0600 (Fri, 16 Jan 2009) | 15 lines

Merged revisions 169044 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r169044 | twilson | 2009-01-16 18:03:39 -0600 (Fri, 16 Jan 2009) | 8 lines
 
 Fix port :0 added to SIP INVITE URI when outboundproxy used
 
 (closes issue ASTERISK-13359)
 Reported by: chris-mac
 Patches:
       asterisk-bug14233.diff.txt uploaded by jamesgolovich (license 176)
 Tested by: jamesgolovich, chris-mac, otherwiseguy
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=169079