Summary:	ASTERISK-13320: upgrading from asterisk-1.6.0.3 to branch/asterisk-1.6.1 breaks qualify for TCP peer
Reporter:	Paul Belanger (pabelanger)	Labels:
Date Opened:	2009-01-07 15:53:05.000-0600	Date Closed:	2009-01-16 19:59:36.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-1.6.0.3 ( 1) asterisk-branch-1.6.1 ( 2) asterisk-bug14192.diff.txt
Description:	We are in the process of testing the 1.6.1 branch, so we can upgrade a few sites, but qualify on TCP sip peers appears to be broken now. Using the same working .configs from asterisk-1.6.0.3, no longer work using asterisk-1.6.1. ****** ADDITIONAL INFORMATION ****** Attaching output for both 1.6.0.3 and branch/1.6.1.
Comments:	By: Paul Belanger (pabelanger) 2009-01-07 15:57:55.000-0600 I believe the problem is OPTIONS message from asterisk is not sent out to the Ethernet interface.   A tcpdump from both side (asterisk box and remote peer) does not show any trace of the OPTIONS message. By: Leif Madsen (lmadsen) 2009-01-09 12:57:35.000-0600 Assigned this issue to otherwiseguy to look into this issue further. Unfortunately I don't have a TCP phone setup right now on my development system in which to test this. By: James Golovich (jamesgolovich) 2009-01-12 23:03:45.000-0600 Give this patch a try, should solve the problem, any TCP client would have been broken since revision 151101 Took a while to figure this one out, was initially working it from the SIP side when I finally got down and noticed we weren't even setting up a session at all Note to self:  I need to talk to kpfleming on this to see if he thinks we need both a old_local_address and a old_remote_address, or if just a old_address is fine (like what is in the patch). By: James Golovich (jamesgolovich) 2009-01-14 15:12:27.000-0600 I checked with Kevin and the patch does the proper thing.  We don't need a old_local_address and old_remote_address, just one old_address will work fine By: Digium Subversion (svnbot) 2009-01-16 19:56:34.000-0600 Repository: asterisk Revision: 169080 U   trunk/include/asterisk/tcptls.h U   trunk/main/http.c U   trunk/main/tcptls.c ------------------------------------------------------------------------ r169080 | twilson | 2009-01-16 19:56:34 -0600 (Fri, 16 Jan 2009) | 8 lines Fix qualify for TCP peer (closes issue ASTERISK-13320) Reported by: pabelanger Patches:      asterisk-bug14192.diff.txt uploaded by jamesgolovich (license 176) Tested by: jamesgolovich ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=169080 By: Digium Subversion (svnbot) 2009-01-16 19:57:38.000-0600 Repository: asterisk Revision: 169081 _U  branches/1.6.0/ ------------------------------------------------------------------------ r169081 | twilson | 2009-01-16 19:57:38 -0600 (Fri, 16 Jan 2009) | 14 lines Blocked revisions 169080 via svnmerge ........  r169080 | twilson | 2009-01-16 19:56:36 -0600 (Fri, 16 Jan 2009) | 8 lines    Fix qualify for TCP peer    (closes issue ASTERISK-13320)  Reported by: pabelanger  Patches:        asterisk-bug14192.diff.txt uploaded by jamesgolovich (license 176)  Tested by: jamesgolovich ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=169081 By: Digium Subversion (svnbot) 2009-01-16 19:59:35.000-0600 Repository: asterisk Revision: 169082 _U  branches/1.6.1/ U   branches/1.6.1/include/asterisk/tcptls.h U   branches/1.6.1/main/http.c U   branches/1.6.1/main/tcptls.c ------------------------------------------------------------------------ r169082 | twilson | 2009-01-16 19:59:35 -0600 (Fri, 16 Jan 2009) | 15 lines Merged revisions 169080 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r169080 | twilson | 2009-01-16 19:56:36 -0600 (Fri, 16 Jan 2009) | 8 lines    Fix qualify for TCP peer    (closes issue ASTERISK-13320)  Reported by: pabelanger  Patches:        asterisk-bug14192.diff.txt uploaded by jamesgolovich (license 176)  Tested by: jamesgolovich ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=169082