[Home]

Summary:ASTERISK-13306: [patch] ast_db_gettree(family, keytree) completely ignores the keytree argument
Reporter:Nic Bellamy (nic_bellamy)Labels:
Date Opened:2009-01-05 22:29:11.000-0600Date Closed:2009-06-11 10:40:18
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-trunk-svn-r167242-ast_db_gettree.patch
Description:Small bug in ast_db_gettree() - due to a trivial thinko, the keytree argument is completely ignored.

Hasn't been an issue so far, as nothing within Asterisk itself was using the keytree argument - but then I started writing some code that used it....

****** ADDITIONAL INFORMATION ******

process_clearcache() in pbx/pbx_dundi.c is doing this:

db_entry = db_tree = ast_db_gettree("dundi/cache", NULL);

... when it should probably be doing this:

db_entry = db_tree = ast_db_gettree("dundi", "cache");

It was probably written like this due to the keytree argument not working :-)

I haven't included this in the patch as it is outside the scope of my ability to test right now.
Comments:By: Digium Subversion (svnbot) 2009-01-06 15:35:57.000-0600

Repository: asterisk
Revision: 167299

U   branches/1.4/main/db.c

------------------------------------------------------------------------
r167299 | mmichelson | 2009-01-06 15:35:57 -0600 (Tue, 06 Jan 2009) | 8 lines

Use the correct variable when creating the format string

(closes issue ASTERISK-13306)
Reported by: nic_bellamy
Patches:
     asterisk-trunk-svn-r167242-ast_db_gettree.patch uploaded by nic (license 299)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167299

By: Digium Subversion (svnbot) 2009-01-06 15:36:41.000-0600

Repository: asterisk
Revision: 167301

_U  trunk/
U   trunk/main/db.c

------------------------------------------------------------------------
r167301 | mmichelson | 2009-01-06 15:36:40 -0600 (Tue, 06 Jan 2009) | 16 lines

Merged revisions 167299 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r167299 | mmichelson | 2009-01-06 15:35:57 -0600 (Tue, 06 Jan 2009) | 8 lines

Use the correct variable when creating the format string

(closes issue ASTERISK-13306)
Reported by: nic_bellamy
Patches:
     asterisk-trunk-svn-r167242-ast_db_gettree.patch uploaded by nic (license 299)


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167301

By: Digium Subversion (svnbot) 2009-01-06 15:38:16.000-0600

Repository: asterisk
Revision: 167304

_U  branches/1.6.0/
U   branches/1.6.0/main/db.c

------------------------------------------------------------------------
r167304 | mmichelson | 2009-01-06 15:38:16 -0600 (Tue, 06 Jan 2009) | 24 lines

Merged revisions 167301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r167301 | mmichelson | 2009-01-06 15:36:44 -0600 (Tue, 06 Jan 2009) | 16 lines

Merged revisions 167299 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r167299 | mmichelson | 2009-01-06 15:35:57 -0600 (Tue, 06 Jan 2009) | 8 lines

Use the correct variable when creating the format string

(closes issue ASTERISK-13306)
Reported by: nic_bellamy
Patches:
     asterisk-trunk-svn-r167242-ast_db_gettree.patch uploaded by nic (license 299)


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167304

By: Digium Subversion (svnbot) 2009-01-06 15:38:41.000-0600

Repository: asterisk
Revision: 167306

_U  branches/1.6.1/
U   branches/1.6.1/main/db.c

------------------------------------------------------------------------
r167306 | mmichelson | 2009-01-06 15:38:41 -0600 (Tue, 06 Jan 2009) | 24 lines

Merged revisions 167301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r167301 | mmichelson | 2009-01-06 15:36:44 -0600 (Tue, 06 Jan 2009) | 16 lines

Merged revisions 167299 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r167299 | mmichelson | 2009-01-06 15:35:57 -0600 (Tue, 06 Jan 2009) | 8 lines

Use the correct variable when creating the format string

(closes issue ASTERISK-13306)
Reported by: nic_bellamy
Patches:
     asterisk-trunk-svn-r167242-ast_db_gettree.patch uploaded by nic (license 299)


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167306