[Home]

Summary:ASTERISK-13305: [patch] send out the incorrect register request URI to the (fromdomain) outbound proxy
Reporter:Szu-Ming Lee (paraeco)Labels:
Date Opened:2009-01-05 21:31:21.000-0600Date Closed:2009-05-20 06:58:10
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:Channels/chan_sip/Registration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.c.diff
Description:It is actually reopening the issue ASTERISK-11876 .
A bug is introduced into the file channel/chan_sip.c in the asterisk 1.4 branch -- SVN revision #126902.

ast_string_field_set(p, fromdomain, ++fromdomain);

In the above code, ++fromdomain would be executed twice in the macro ast_string_field_set() .
It results in the first character of the domain name to be eliminated .
A fix is included in the additional information filed .

Edit: the fix has been removed as all patch submissions MUST be posted to the tracker correctly; not inline.


****** ADDITIONAL INFORMATION ******

Edit: Code removed as it should not be posted inline into the notes.
Comments:By: Leif Madsen (lmadsen) 2009-01-06 08:43:10.000-0600

You need to post patches to the bug tracker correctly in order for them to be validated against the licensing server. If you have not already filled out a license, please do so, and it will be approved as soon as possible. You should see a link at the top in the main bar.

After attaching an issue, please mark it as a code or documentation submission, and it will be looked at as soon as possible. Thanks!
By: Szu-Ming Lee (paraeco) 2009-01-07 21:24:13.000-0600

The patch file is attached but it shows "License PENDING" .
I should have signed the license agreement but why ..?
By: Leif Madsen (lmadsen) 2009-01-08 07:31:33.000-0600

Hi paraeco,

Thanks for signing the license. For more information about why you needed to sign the license, check out the Bug Guidelines at http://www.asterisk.org/developers/bug-guidelines

Read the section titled, "The license contributor agreement".

Thanks!
By: Szu-Ming Lee (paraeco) 2009-01-08 20:20:00.000-0600

In SVN, the the macro has been patched to fix/prevent the same problem.
Thanks.
By: Leif Madsen (lmadsen) 2009-01-13 12:12:43.000-0600

Are you saying this issue can be closed?
By: Leif Madsen (lmadsen) 2009-01-13 12:16:14.000-0600

Oh, I think you are saying that this issue is already fixed in SVN?
By: Terry Wilson (twilson) 2009-01-13 12:34:06.000-0600

Whether the macro was fixed or not, I don't like passing a value with a side effect to a macro anyway, so I'm committing this since it looks right.
By: Digium Subversion (svnbot) 2009-01-13 12:34:15.000-0600

Repository: asterisk
Revision: 168551

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r168551 | twilson | 2009-01-13 12:34:14 -0600 (Tue, 13 Jan 2009) | 7 lines

Don't pass a value with a side effect to a macro

(closes issue ASTERISK-13305)
Reported by: paraeco
Patches:
     chan_sip.c.diff uploaded by paraeco (license 658)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=168551
By: Digium Subversion (svnbot) 2009-01-13 16:22:35.000-0600

Repository: asterisk
Revision: 168578

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r168578 | twilson | 2009-01-13 16:22:35 -0600 (Tue, 13 Jan 2009) | 14 lines

Merged revisions 168551 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r168551 | twilson | 2009-01-13 12:34:14 -0600 (Tue, 13 Jan 2009) | 7 lines
 
 Don't pass a value with a side effect to a macro
 
 (closes issue ASTERISK-13305)
 Reported by: paraeco
 Patches:
       chan_sip.c.diff uploaded by paraeco (license 658)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=168578
By: Digium Subversion (svnbot) 2009-01-13 16:31:21.000-0600

Repository: asterisk
Revision: 168580

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r168580 | twilson | 2009-01-13 16:31:21 -0600 (Tue, 13 Jan 2009) | 21 lines

Merged revisions 168578 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r168578 | twilson | 2009-01-13 16:22:34 -0600 (Tue, 13 Jan 2009) | 14 lines
 
 Merged revisions 168551 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r168551 | twilson | 2009-01-13 12:34:14 -0600 (Tue, 13 Jan 2009) | 7 lines
   
   Don't pass a value with a side effect to a macro
   
   (closes issue ASTERISK-13305)
   Reported by: paraeco
   Patches:
         chan_sip.c.diff uploaded by paraeco (license 658)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=168580
By: Digium Subversion (svnbot) 2009-01-13 16:38:22.000-0600

Repository: asterisk
Revision: 168582

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r168582 | twilson | 2009-01-13 16:38:22 -0600 (Tue, 13 Jan 2009) | 21 lines

Merged revisions 168578 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r168578 | twilson | 2009-01-13 16:22:34 -0600 (Tue, 13 Jan 2009) | 14 lines
 
 Merged revisions 168551 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r168551 | twilson | 2009-01-13 12:34:14 -0600 (Tue, 13 Jan 2009) | 7 lines
   
   Don't pass a value with a side effect to a macro
   
   (closes issue ASTERISK-13305)
   Reported by: paraeco
   Patches:
         chan_sip.c.diff uploaded by paraeco (license 658)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=168582