Summary: | ASTERISK-13301: [patch] Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete. | ||
Reporter: | Eliel Sardanons (eliel) | Labels: | |
Date Opened: | 2009-01-30 13:10:54.000-0600 | Date Closed: | 2009-03-25 10:33:25 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) asterisk.c.patch | |
Description: | When moving the cursor backward and pressing TAB to autocomplete a NULL is put in the line and we are loosing what we have already wrote after the actual cursor position. core show channel<CURSOR>'\0' pepe If moving the cursor where <CURSOR> is and pressing tab, the autocompletion mechanism autocomplete the line but puts a NULL and 'pepe' is no more part of the command line. | ||
Comments: | By: Leif Madsen (lmadsen) 2009-02-26 17:27:35.000-0600 Assigning to myself so I can attempt to reproduce the issue, and then this patch. By: Leif Madsen (lmadsen) 2009-02-27 12:19:25.000-0600 This works great! By: Jason Parker (jparker) 2009-03-17 17:07:28 lmadsen says this is good, so I'll commit - just need a clarification on where this should go. 1.4 and above? By: Leif Madsen (lmadsen) 2009-03-18 09:03:19 Talked to eliel on IRC, and I think this should go into 1.4 and forward. By: Digium Subversion (svnbot) 2009-03-25 09:12:57 Repository: asterisk Revision: 184188 U branches/1.4/main/asterisk.c ------------------------------------------------------------------------ r184188 | eliel | 2009-03-25 09:12:55 -0500 (Wed, 25 Mar 2009) | 13 lines Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete. When moving the cursor backward and pressing TAB to autocomplete, a NULL is put in the line and we are loosing what we have already wrote after the actual cursor position. (closes issue ASTERISK-13301) Reported by: eliel Patches: asterisk.c.patch uploaded by eliel (license 64) Tested by: lmadsen ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=184188 By: Digium Subversion (svnbot) 2009-03-25 09:38:20 Repository: asterisk Revision: 184220 _U trunk/ U trunk/main/asterisk.c ------------------------------------------------------------------------ r184220 | eliel | 2009-03-25 09:38:19 -0500 (Wed, 25 Mar 2009) | 19 lines Merged revisions 184188 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184188 | eliel | 2009-03-25 10:12:54 -0400 (Wed, 25 Mar 2009) | 13 lines Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete. When moving the cursor backward and pressing TAB to autocomplete, a NULL is put in the line and we are loosing what we have already wrote after the actual cursor position. (closes issue ASTERISK-13301) Reported by: eliel Patches: asterisk.c.patch uploaded by eliel (license 64) Tested by: lmadsen ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=184220 By: Digium Subversion (svnbot) 2009-03-25 09:52:22 Repository: asterisk Revision: 184222 _U branches/1.6.0/ U branches/1.6.0/main/asterisk.c ------------------------------------------------------------------------ r184222 | eliel | 2009-03-25 09:52:22 -0500 (Wed, 25 Mar 2009) | 26 lines Merged revisions 184220 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184220 | eliel | 2009-03-25 10:38:19 -0400 (Wed, 25 Mar 2009) | 19 lines Merged revisions 184188 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184188 | eliel | 2009-03-25 10:12:54 -0400 (Wed, 25 Mar 2009) | 13 lines Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete. When moving the cursor backward and pressing TAB to autocomplete, a NULL is put in the line and we are loosing what we have already wrote after the actual cursor position. (closes issue ASTERISK-13301) Reported by: eliel Patches: asterisk.c.patch uploaded by eliel (license 64) Tested by: lmadsen ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=184222 By: Digium Subversion (svnbot) 2009-03-25 10:12:09 Repository: asterisk Revision: 184223 _U branches/1.6.1/ U branches/1.6.1/main/asterisk.c ------------------------------------------------------------------------ r184223 | eliel | 2009-03-25 10:12:08 -0500 (Wed, 25 Mar 2009) | 26 lines Merged revisions 184220 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184220 | eliel | 2009-03-25 10:38:19 -0400 (Wed, 25 Mar 2009) | 19 lines Merged revisions 184188 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184188 | eliel | 2009-03-25 10:12:54 -0400 (Wed, 25 Mar 2009) | 13 lines Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete. When moving the cursor backward and pressing TAB to autocomplete, a NULL is put in the line and we are loosing what we have already wrote after the actual cursor position. (closes issue ASTERISK-13301) Reported by: eliel Patches: asterisk.c.patch uploaded by eliel (license 64) Tested by: lmadsen ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=184223 By: Digium Subversion (svnbot) 2009-03-25 10:33:25 Repository: asterisk Revision: 184256 _U branches/1.6.2/ U branches/1.6.2/main/asterisk.c ------------------------------------------------------------------------ r184256 | eliel | 2009-03-25 10:33:25 -0500 (Wed, 25 Mar 2009) | 26 lines Merged revisions 184220 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184220 | eliel | 2009-03-25 10:38:19 -0400 (Wed, 25 Mar 2009) | 19 lines Merged revisions 184188 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184188 | eliel | 2009-03-25 10:12:54 -0400 (Wed, 25 Mar 2009) | 13 lines Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete. When moving the cursor backward and pressing TAB to autocomplete, a NULL is put in the line and we are loosing what we have already wrote after the actual cursor position. (closes issue ASTERISK-13301) Reported by: eliel Patches: asterisk.c.patch uploaded by eliel (license 64) Tested by: lmadsen ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=184256 |