Summary: | ASTERISK-13274: [patch] followme should answer the call | ||
Reporter: | Dmitry Andrianov (dimas) | Labels: | |
Date Opened: | 2008-12-25 14:35:34.000-0600 | Date Closed: | 2009-01-07 12:32:53.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_followme |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) 14140.patch | |
Description: | Before followme starts playing any audio it should answer the call. Patch is trivial (attached). 1.4 have the same problem. Sunce this is minor issue, I'm not sure you accepting patches for these in 1.4. In any case it is really trivial to find the same place in the app_exec function and put the same code. | ||
Comments: | By: Andrew Lindh (andrew) 2008-12-26 20:05:40.000-0600 I'm not sure we always want the call answered. May be an option to answer or not, like other apps.... You can always add an "Answer" before "FollowMe" By: Dmitry Andrianov (dimas) 2008-12-27 06:09:53.000-0600 Well, Answer before FollowMe is not the same as answer inside followme. In my setup I send all unanswered calls to Followme but only a few users have followme configured. For the rest, followme just says that there is no profile with such id and exists and dialplan continues to voicemail. If I put Answer before Followme, it will be answering the call even for those who does not have followme profile which is not good. I wonder why someone may need Followme on the call which is not answered. By: Leif Madsen (lmadsen) 2009-01-07 12:00:21.000-0600 Confirming issue and assigning to bweschke for now! Reassign as necessary. Thanks! By: Digium Subversion (svnbot) 2009-01-07 12:20:27.000-0600 Repository: asterisk Revision: 167478 U trunk/apps/app_followme.c ------------------------------------------------------------------------ r167478 | bweschke | 2009-01-07 12:20:27 -0600 (Wed, 07 Jan 2009) | 7 lines Answer the channel if it has not already been answered and we've already found a valid profile for followme. (closes issue ASTERISK-13274) Reported by: dimas Patches: 14140.patch uploaded by dimas ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=167478 By: Digium Subversion (svnbot) 2009-01-07 12:30:38.000-0600 Repository: asterisk Revision: 167498 _U branches/1.6.0/ U branches/1.6.0/apps/app_followme.c ------------------------------------------------------------------------ r167498 | bweschke | 2009-01-07 12:30:38 -0600 (Wed, 07 Jan 2009) | 13 lines Merged revisions 167478 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r167478 | bweschke | 2009-01-07 13:20:31 -0500 (Wed, 07 Jan 2009) | 7 lines Answer the channel if it has not already been answered and we've already found a valid profile for followme. (closes issue ASTERISK-13274) Reported by: dimas Patches: 14140.patch uploaded by dimas ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=167498 By: Digium Subversion (svnbot) 2009-01-07 12:32:52.000-0600 Repository: asterisk Revision: 167502 _U branches/1.6.1/ U branches/1.6.1/apps/app_followme.c ------------------------------------------------------------------------ r167502 | bweschke | 2009-01-07 12:32:52 -0600 (Wed, 07 Jan 2009) | 13 lines Merged revisions 167478 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r167478 | bweschke | 2009-01-07 13:20:31 -0500 (Wed, 07 Jan 2009) | 7 lines Answer the channel if it has not already been answered and we've already found a valid profile for followme. (closes issue ASTERISK-13274) Reported by: dimas Patches: 14140.patch uploaded by dimas ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=167502 |