Summary:	ASTERISK-13251: Incorrect processing of "maxuser" parameter in real-time meetme
Reporter:	Serge De Vorop (sergedevorop)	Labels:
Date Opened:	2008-12-19 13:48:09.000-0600	Date Closed:	2009-01-15 09:37:49.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_meetme
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 20090113__bug14117.diff.txt ( 1) 20090114__bug14117.diff.txt ( 2) 20090114__bug14117-2.diff.txt
Description:	I compile app_meetme with enable realtime.   rt_schedule = 1;   fuzzystart = 1;   earlyalert = 1;   endalert = 1;   extendby = 1; Also I create a table which include `maxusers` field. Conference work fine but with some bug. Imaging that I book conference with maxusers==2. - 1st participant call to the asterisk, connect to the room and listen MOH (music on hold) - 2nd one call to the asterisk, connect to the room and listen MOH - 3d one call to the Asterisk, enter the room_number, enter pin and get play sound that "conference is full". - 4th one call to the Asterisk, enter the room_number, enter pin and no any sounds. Asterisk log show that las message was play "get pin number". - If then conference will be not full, for example include only 1 participant any other calls to the conference will be processed like 4th. What does it may be?
Comments:	By: Sean Bright (seanbright) 2009-01-13 15:26:02.000-0600 Could you try the attached patch and report back the results? By: Serge De Vorop (sergedevorop) 2009-01-14 06:16:53.000-0600 Hi, I've installed attached patch but the common bug was not solved. But to tell the truth the situation is a little bit different. - 1st participant call to the asterisk, connect to the room and listen MOH (music on hold) - 2nd one call to the asterisk, connect to the room and listen MOH - 3d one call to the Asterisk, enter the room_number, enter pin and get play sound that "conference is full". - 2nd one hang-up. - 3d one call to the asterisk, connect to the room and listen MOH. So it seems that all OK. But this is not true. - 2nd one call to the Asterisk, enter the room_number, enter pin and get play sound that "conference is full". - After that all calls to the Asterisk to this room_number failed with play sound that "conference is full" in spite of either i is really full or not. By: Sean Bright (seanbright) 2009-01-14 08:31:36.000-0600 Could you please try the new patch and report back the results?  You'll need to run 'svn revert apps/app_meetme.c' before applying the new one, otherwise the patch will fail. By: Sean Bright (seanbright) 2009-01-14 08:59:49.000-0600 Actually, I see what the problem is now.  The previous two patches won't fix it completely.  I'll whip up another one in an hour or so. By: Sean Bright (seanbright) 2009-01-14 10:00:58.000-0600 Please try with the latest patch 20090114__bug14117-2.diff.txt Again, you will need to 'svn revert apps/app_meetme.c' from the root of your asterisk source directory before the patch will apply successfully. By: Serge De Vorop (sergedevorop) 2009-01-15 03:00:33.000-0600 Seanbright, I've tried the latest patch. Looks like now all OK with asterisk and maxusers parameter. Great thanks!!! Does this patch will be applied to new SVN-TRUNK version of Asterisk? By: Sean Bright (seanbright) 2009-01-15 09:25:31.000-0600 Yes, and any branches where it is also a problem. By: Digium Subversion (svnbot) 2009-01-15 09:33:19.000-0600 Repository: asterisk Revision: 168705 U   trunk/apps/app_meetme.c ------------------------------------------------------------------------ r168705 | seanbright | 2009-01-15 09:33:19 -0600 (Thu, 15 Jan 2009) | 11 lines Add a missing unlock and properly handle the 'maxusers' setting on MeetMe conferences.  We were using the 'user number' field to compare against the maximum allowed users, which works assuming users with lower user numbers didn't leave the conference. (closes issue ASTERISK-13251) Reported by: sergedevorop Patches:      20090114__bug14117-2.diff.txt uploaded by seanbright (license 71) Tested by: sergedevorop ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=168705 By: Digium Subversion (svnbot) 2009-01-15 09:34:35.000-0600 Repository: asterisk Revision: 168706 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_meetme.c ------------------------------------------------------------------------ r168706 | seanbright | 2009-01-15 09:34:35 -0600 (Thu, 15 Jan 2009) | 18 lines Merged revisions 168705 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r168705 | seanbright | 2009-01-15 10:33:18 -0500 (Thu, 15 Jan 2009) | 11 lines    Add a missing unlock and properly handle the 'maxusers' setting on MeetMe  conferences.  We were using the 'user number' field to compare against the  maximum allowed users, which works assuming users with lower user numbers  didn't leave the conference.    (closes issue ASTERISK-13251)  Reported by: sergedevorop  Patches:        20090114__bug14117-2.diff.txt uploaded by seanbright (license 71)  Tested by: sergedevorop ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=168706 By: Digium Subversion (svnbot) 2009-01-15 09:37:49.000-0600 Repository: asterisk Revision: 168707 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_meetme.c ------------------------------------------------------------------------ r168707 | seanbright | 2009-01-15 09:37:49 -0600 (Thu, 15 Jan 2009) | 18 lines Merged revisions 168705 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r168705 | seanbright | 2009-01-15 10:33:18 -0500 (Thu, 15 Jan 2009) | 11 lines    Add a missing unlock and properly handle the 'maxusers' setting on MeetMe  conferences.  We were using the 'user number' field to compare against the  maximum allowed users, which works assuming users with lower user numbers  didn't leave the conference.    (closes issue ASTERISK-13251)  Reported by: sergedevorop  Patches:        20090114__bug14117-2.diff.txt uploaded by seanbright (license 71)  Tested by: sergedevorop ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=168707