[Home]

Summary:ASTERISK-13236: kill() does not kill all processes
Reporter:caspy (caspy)Labels:
Date Opened:2008-12-17 06:26:41.000-0600Date Closed:2008-12-18 12:58:01.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_musiconhold.c.patch.killpg
( 1) res_musiconhold.c.patch.killpg.try2
Description:if MoH application forks it own childs, then res_musiconhold.c kill's only first of them, leaving forked subprocesses alone.

****** ADDITIONAL INFORMATION ******

if just before fork() we do:
setpgid(0, getpid());
than we can kill all childs with killpg() instead of kill().
Comments:By: Leif Madsen (lmadsen) 2008-12-17 09:29:29.000-0600

Your license has been rejected, thus we cannot look at your patch that you have provided. Please resubmit a valid license and reupload your patch to this issue. Thanks!
By: Leif Madsen (lmadsen) 2008-12-17 09:30:34.000-0600

Assigned to russell. This has been set to 'needs license' but perhaps there is enough information in this bug that you can fix it without the proposed patch (which is not available due to rejected license).

If this is not the case, please just unassign yourself from the issue. Thanks!
By: caspy (caspy) 2008-12-17 11:12:47.000-0600

i have resubmitted a correct license.
so, the same patch once again.


ps: i can't find a place for "unassign". ;)
By: Digium Subversion (svnbot) 2008-12-18 12:52:13.000-0600

Repository: asterisk
Revision: 165661

U   branches/1.4/res/res_musiconhold.c

------------------------------------------------------------------------
r165661 | russell | 2008-12-18 12:52:13 -0600 (Thu, 18 Dec 2008) | 7 lines

Set the process group ID on the MOH process so that all children will get killed

(closes issue ASTERISK-13236)
Reported by: caspy
Patches:
     res_musiconhold.c.patch.killpg.try2 uploaded by caspy (license 645)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=165661
By: Digium Subversion (svnbot) 2008-12-18 12:54:43.000-0600

Repository: asterisk
Revision: 165662

_U  trunk/
U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r165662 | russell | 2008-12-18 12:54:43 -0600 (Thu, 18 Dec 2008) | 15 lines

Merged revisions 165661 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r165661 | russell | 2008-12-18 12:52:18 -0600 (Thu, 18 Dec 2008) | 7 lines

Set the process group ID on the MOH process so that all children will get killed

(closes issue ASTERISK-13236)
Reported by: caspy
Patches:
     res_musiconhold.c.patch.killpg.try2 uploaded by caspy (license 645)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=165662
By: Digium Subversion (svnbot) 2008-12-18 12:56:28.000-0600

Repository: asterisk
Revision: 165663

_U  branches/1.6.0/
U   branches/1.6.0/res/res_musiconhold.c

------------------------------------------------------------------------
r165663 | russell | 2008-12-18 12:56:27 -0600 (Thu, 18 Dec 2008) | 23 lines

Merged revisions 165662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r165662 | russell | 2008-12-18 12:54:47 -0600 (Thu, 18 Dec 2008) | 15 lines

Merged revisions 165661 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r165661 | russell | 2008-12-18 12:52:18 -0600 (Thu, 18 Dec 2008) | 7 lines

Set the process group ID on the MOH process so that all children will get killed

(closes issue ASTERISK-13236)
Reported by: caspy
Patches:
     res_musiconhold.c.patch.killpg.try2 uploaded by caspy (license 645)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=165663
By: Digium Subversion (svnbot) 2008-12-18 12:58:00.000-0600

Repository: asterisk
Revision: 165664

_U  branches/1.6.1/
U   branches/1.6.1/res/res_musiconhold.c

------------------------------------------------------------------------
r165664 | russell | 2008-12-18 12:58:00 -0600 (Thu, 18 Dec 2008) | 23 lines

Merged revisions 165662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r165662 | russell | 2008-12-18 12:54:47 -0600 (Thu, 18 Dec 2008) | 15 lines

Merged revisions 165661 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r165661 | russell | 2008-12-18 12:52:18 -0600 (Thu, 18 Dec 2008) | 7 lines

Set the process group ID on the MOH process so that all children will get killed

(closes issue ASTERISK-13236)
Reported by: caspy
Patches:
     res_musiconhold.c.patch.killpg.try2 uploaded by caspy (license 645)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=165664