[Home]

Summary:ASTERISK-13211: too small reponse for dbget through agi
Reporter:evandro (evandro)Labels:
Date Opened:2008-12-12 11:22:26.000-0600Date Closed:2009-01-08 16:45:30.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20081214__bug14069.diff.txt
Description:I'm using agi to get persistent members in queues, but the response in some cases come incomplete, when have too many members in queue. I changed the size of char tmp variable from 256 to 1024 on res/res_agi.c file, and fixed this issue in a sample test. But I want to know, this change can cause problems??
I also would suggest that this changed to be applied in asterisk and asterisk CLI.
Comments:By: Leif Madsen (lmadsen) 2008-12-12 11:25:12.000-0600

Assigned to Corydon76 to verify.
By: Tilghman Lesher (tilghman) 2008-12-14 01:00:07.000-0600

I'd go with this patch, instead.  Unfortunately, simply increasing the size of a static buffer can get us into trouble, especially for people who call AGI within several layers of Macro.  This patch dynamically allocates space on the heap and automatically grows to the appropriate size for the buffer.  In trunk (1.6.0 and later), we have a much better system for dynamically allocating space for string management, but this change will work fine for 1.4.
By: Tilghman Lesher (tilghman) 2008-12-14 01:01:10.000-0600

In any case, this is unlikely to get changed for 1.4, but this issue is a good reminder that we need to ast_str-ify res_agi.c.
By: Digium Subversion (svnbot) 2009-01-08 16:08:49.000-0600

Repository: asterisk
Revision: 167840

U   branches/1.4/res/res_agi.c

------------------------------------------------------------------------
r167840 | tilghman | 2009-01-08 16:08:49 -0600 (Thu, 08 Jan 2009) | 6 lines

Don't truncate database results at 255 chars.
(closes issue ASTERISK-13211)
Reported by: evandro
Patches:
      20081214__bug14069.diff.txt uploaded by Corydon76 (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167840
By: Digium Subversion (svnbot) 2009-01-08 16:37:14.000-0600

Repository: asterisk
Revision: 167894

_U  trunk/
U   trunk/res/res_agi.c

------------------------------------------------------------------------
r167894 | tilghman | 2009-01-08 16:37:14 -0600 (Thu, 08 Jan 2009) | 13 lines

Merged revisions 167840 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r167840 | tilghman | 2009-01-08 16:08:56 -0600 (Thu, 08 Jan 2009) | 6 lines
 
 Don't truncate database results at 255 chars.
 (closes issue ASTERISK-13211)
  Reported by: evandro
  Patches:
        20081214__bug14069.diff.txt uploaded by Corydon76 (license 14)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167894
By: Digium Subversion (svnbot) 2009-01-08 16:42:24.000-0600

Repository: asterisk
Revision: 167904

_U  branches/1.6.0/
U   branches/1.6.0/res/res_agi.c

------------------------------------------------------------------------
r167904 | tilghman | 2009-01-08 16:42:24 -0600 (Thu, 08 Jan 2009) | 20 lines

Merged revisions 167894 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r167894 | tilghman | 2009-01-08 16:37:20 -0600 (Thu, 08 Jan 2009) | 13 lines
 
 Merged revisions 167840 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r167840 | tilghman | 2009-01-08 16:08:56 -0600 (Thu, 08 Jan 2009) | 6 lines
   
   Don't truncate database results at 255 chars.
   (closes issue ASTERISK-13211)
    Reported by: evandro
    Patches:
          20081214__bug14069.diff.txt uploaded by Corydon76 (license 14)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167904
By: Digium Subversion (svnbot) 2009-01-08 16:45:30.000-0600

Repository: asterisk
Revision: 167905

_U  branches/1.6.1/
U   branches/1.6.1/res/res_agi.c

------------------------------------------------------------------------
r167905 | tilghman | 2009-01-08 16:45:30 -0600 (Thu, 08 Jan 2009) | 20 lines

Merged revisions 167894 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r167894 | tilghman | 2009-01-08 16:37:20 -0600 (Thu, 08 Jan 2009) | 13 lines
 
 Merged revisions 167840 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r167840 | tilghman | 2009-01-08 16:08:56 -0600 (Thu, 08 Jan 2009) | 6 lines
   
   Don't truncate database results at 255 chars.
   (closes issue ASTERISK-13211)
    Reported by: evandro
    Patches:
          20081214__bug14069.diff.txt uploaded by Corydon76 (license 14)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=167905