[Home]

Summary:ASTERISK-13160: Channel "hangs"
Reporter:Daniel A. Veiga (dveiga)Labels:
Date Opened:2008-12-02 21:29:48.000-0600Date Closed:2008-12-08 12:48:16.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:PBX/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 14012.patch
Description:Function collect_digits() in main/pbx.c calls ast_waitfordigit() passing waittime*1000 as a paramenter, but waittime is already in milliseconds! Thus, ast_waitfordigit() takes a REAL LONG TIME to return, making the user think the channel is "hanged".


****** ADDITIONAL INFORMATION ******

Just delete "*1000" in function call
Comments:By: Brandon Kruse (bkruse) 2008-12-05 12:03:11.000-0600

This is in fact true. waittime is either set to c->pbx->dtimeoutms or c->pbx->rtimeoutms.

The default options for these are 10000 and 5000 respectively.

Attaching a patch, just for giggles.

-bk
By: Brandon Kruse (bkruse) 2008-12-05 12:19:19.000-0600

Can you give me some steps to reproduce this bug?

Thanks,

-bk
By: Digium Subversion (svnbot) 2008-12-08 12:48:15.000-0600

Repository: asterisk
Revision: 161787

U   trunk/main/pbx.c

------------------------------------------------------------------------
r161787 | file | 2008-12-08 12:48:15 -0600 (Mon, 08 Dec 2008) | 6 lines

Fix a regression introduced when the PBX timeouts were converted to milliseconds. collect_digits now gets milliseconds fed to it, not seconds.
(closes issue ASTERISK-13160)
Reported by: dveiga
Patches:
     14012.patch uploaded by bkruse (license 132)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=161787