Summary: | ASTERISK-13153: Pickup() can't pickup calls to some SIP devices | ||
Reporter: | Dan Lanciani (ddl) | Labels: | |
Date Opened: | 2008-12-01 18:28:06.000-0600 | Date Closed: | 2011-05-27 09:13:32 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_directed_pickup |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | I've observed that when a SIP device responds to an INVITE with a 183 without ever sending a 180 the outgoing channel remains in the Down state rather than moving to Ring[ing]. This prevents Pickup() from picking up the call. I did some extensive Google searching to try to understand the Pickup() failures and generally found a lot of reports where Pickup() seemed to work in some cases but not in others. I wonder if this could be the root cause of some of the confusion. By adding AST_STATE_DOWN to the test in app_directed_pickup.c I was able to get Pickup() to work with SIP devices (in this case the FXS port on a Cisco router) that behave as above; however, I have no idea what collateral damage this might cause. It feels like there should be some other state for call progressing. I am using 1.4.11 as provided in the FreeBSD 6.3 port. I apologize if this has already been addressed in a newer version. I checked 1.4.22 and the code appeared the same. | ||
Comments: | By: Jason Parker (jparker) 2008-12-02 11:53:41.000-0600 It's possible that it was fixed somewhere besides that code. Please try the latest version. By: Dan Lanciani (ddl) 2008-12-02 22:45:17.000-0600 Well, 1.6.0.1 exhibits the same behavior and the same "fix" works. I'm not sure if that is the latest version in the sense that there are different branches in play along with various betas and release candidates. If you have a specific version in mind that might behave differently let me know and I'll try it. By: Digium Subversion (svnbot) 2008-12-09 15:14:53.000-0600 Repository: asterisk Revision: 162341 U branches/1.4/apps/app_directed_pickup.c ------------------------------------------------------------------------ r162341 | file | 2008-12-09 15:14:52 -0600 (Tue, 09 Dec 2008) | 4 lines Add 'down' as a valid state for directed call pickup. This creeps up when we receive session progress when dialing a device and not ringing. (closes issue ASTERISK-13153) Reported by: ddl ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=162341 |