Summary:	ASTERISK-13114: [patch] Average talktime parameter for queues
Reporter:	Miguel Molina (coolmig)	Labels:
Date Opened:	2008-11-24 11:43:45.000-0600	Date Closed:	2009-01-08 16:36:57.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue.c.diff ( 1) app_queue.c.diff.trunk-r158840
Description:	Same as the holdtime parameter, I required to gather the average holdtime value from the queues. This proposed patch adds that functionality. ****** ADDITIONAL INFORMATION ****** I originally wrote ir for asterisk 1.4.22, but I updated it to the latest 1.4 branch SVN revision 158787 as of today.
Comments:	By: Jared Smith (jsmith) 2008-11-24 13:06:21.000-0600 Thanks for this patch... but in order for the developers to easily test it and add it to Asterisk, the patch will need to be against SVN trunk.  (This is because the 1.4 branch is feature frozen, as are the 1.6.0 and 1.6.1 branches.) Can you rework the patch for SVN trunk? By: Miguel Molina (coolmig) 2008-11-24 14:07:15.000-0600 OK, I reworked the patch for the latest SVN trunk code (r158840). You'll find it attached. By: Mark Michelson (mmichelson) 2009-01-08 13:38:05.000-0600 Thanks for the submission. Overall, it's a good patch. There were just two minor issues which I have corrected prior to committing. 1. There was a line in your patch indented with spaces instead of a tab. 2. You forgot to add the extra parameter to update_queue in one instance, so app_queue would not compile. Both of these were trivial to fix, and so I have made the necessary corrections and will be committing the change very soon. Thanks again! By: Digium Subversion (svnbot) 2009-01-08 13:48:36.000-0600 Repository: asterisk Revision: 167792 U   trunk/CHANGES U   trunk/apps/app_queue.c U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r167792 | mmichelson | 2009-01-08 13:48:35 -0600 (Thu, 08 Jan 2009) | 15 lines Add the average talk time for a queue This patch adds the functionality to app_queue of calculating the average amount of time that channels are bridged for a queue. The algorithm used to calculate the average is the same exponential average currently used to calculate the average holdtime. See the CHANGES file to see the methods you may use to view this information. (closes issue ASTERISK-13114) Reported by: coolmig Patches:      app_queue.c.diff.trunk-r158840 uploaded by coolmig (license 621) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=167792 By: Digium Subversion (svnbot) 2009-01-08 16:36:57.000-0600 Repository: asterisk Revision: 167892 _U  branches/1.6.1/ ------------------------------------------------------------------------ r167892 | mmichelson | 2009-01-08 16:36:56 -0600 (Thu, 08 Jan 2009) | 29 lines Blocked revisions 167792,167888 via svnmerge ........ r167792 | mmichelson | 2009-01-08 13:48:42 -0600 (Thu, 08 Jan 2009) | 15 lines Add the average talk time for a queue This patch adds the functionality to app_queue of calculating the average amount of time that channels are bridged for a queue. The algorithm used to calculate the average is the same exponential average currently used to calculate the average holdtime. See the CHANGES file to see the methods you may use to view this information. (closes issue ASTERISK-13114) Reported by: coolmig Patches:      app_queue.c.diff.trunk-r158840 uploaded by coolmig (license 621) ........ r167888 | mmichelson | 2009-01-08 16:34:52 -0600 (Thu, 08 Jan 2009) | 4 lines Revert chan_sip changes which were accidentally committed in revision 167792 ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=167892