| Summary: | ASTERISK-13103: [patch] Skinny switch can still send tones after hangup | ||
| Reporter: | Damien Wedhorn (wedhorn) | Labels: | |
| Date Opened: | 2008-11-22 00:43:00.000-0600 | Date Closed: | 2008-11-22 10:57:09.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_skinny |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) switch.diff | |
| Description: | The switch thread (skinny_ss) sends a reorder tone after the device is hungup if a dialout is abandoned or fails. Subsequent calls to the device (on 30VIP and SP12 at least) result in one-way audio and the reorder tone being played (which results in the wife threatening to take an axe to my asterisk box). ****** ADDITIONAL INFORMATION ****** Attached patch seems to fix the issue. Also included a fix to the skinny_offhook answer routine to mirror the ANSWER softkey (which is more correct). Also included AST_CONTROL_SRCUPDATE in ast2string. And fixed (sort of) a very occasional crash (commented in diff). | ||
| Comments: | By: Digium Subversion (svnbot) 2008-11-22 10:06:33.000-0600 Repository: asterisk Revision: 158688 U trunk/channels/chan_skinny.c ------------------------------------------------------------------------ r158688 | mvanbaak | 2008-11-22 10:06:33 -0600 (Sat, 22 Nov 2008) | 4 lines fix a very occasional core dump in chan_skinny found by wedhorn. (issue ASTERISK-13103) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=158688 By: Michiel van Baak (mvanbaak) 2008-11-22 10:42:18.000-0600 the same bug has made my wife putting an axe in two machines as well. Thank you for fixing it. I'll commit it soon. I'm tearing this patch into seperate pieces and commit them in seperate revisions so we can keep track of individual changes. By: Digium Subversion (svnbot) 2008-11-22 10:48:04.000-0600 Repository: asterisk Revision: 158690 U trunk/channels/chan_skinny.c ------------------------------------------------------------------------ r158690 | mvanbaak | 2008-11-22 10:48:04 -0600 (Sat, 22 Nov 2008) | 4 lines Add Media Source Update to skinny's control2str (issue ASTERISK-13103) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=158690 By: Digium Subversion (svnbot) 2008-11-22 10:57:09.000-0600 Repository: asterisk Revision: 158694 U trunk/channels/chan_skinny.c ------------------------------------------------------------------------ r158694 | mvanbaak | 2008-11-22 10:57:08 -0600 (Sat, 22 Nov 2008) | 8 lines dont send reorder tone after a device is hungup if a dialout is abandoned or failed. Without this reorder tone will play after hangup and both wedhorn's and my wife have threatened to use an axe on our asterisk box (closes issue ASTERISK-13103) Reported by: wedhorn Patches: switch.diff uploaded by wedhorn (license 30) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=158694 | ||