Summary:ASTERISK-13101: [patch] Add new application MinivmMWI to app_minivm.c
Reporter:Bradley Watkins (marquis)Labels:
Date Opened:2008-11-21 14:47:41.000-0600Date Closed:2008-11-24 12:11:04.000-0600
Versions:Frequency of
Environment:Attachments:( 0) minivm_mwi.patch
( 1) minivmmwi_plus_xmldocs.patch
Description:This patch adds a new application for sending MWI to phones via Asterisk's event subsystem.
Comments:By: Terry Wilson (twilson) 2008-11-21 17:29:41.000-0600

Looks good so far, I've tested and it works.  The only change I see that I would like to have before committing is converting to using the new XML documentation system.

By: Bradley Watkins (marquis) 2008-11-21 19:58:57.000-0600

Ok, I'll update the docs to the XML system.  I'm also willing to convert all the docs, not just for the new application.  But should I do that in a separate bug report, or just include it here?

By: Terry Wilson (twilson) 2008-11-22 04:07:05.000-0600

Eh, since you're there just go ahead and include it here.  Thanks!

By: Bradley Watkins (marquis) 2008-11-22 20:08:01.000-0600

OK, here's my first cut at it.  It passes DTD validation (via 'make validate-docs') and doing the various 'core show application Minivm*' commands shows the documentation properly.  I took the liberty to fix a couple of minor spelling/grammar mistakes while I was at it, too.  Let me know if there is anything else I need to do.

By: Digium Subversion (svnbot) 2008-11-24 12:11:03.000-0600

Repository: asterisk
Revision: 158808

U   trunk/apps/app_minivm.c

r158808 | twilson | 2008-11-24 12:11:03 -0600 (Mon, 24 Nov 2008) | 8 lines

This patch adds a new application for sending MWI to phones via Asterisk's event subsystem.  Also, the minivm documentation is all converted to use xmldocs.

(closes issue ASTERISK-13101)
Reported by: Marquis
     minivmmwi_plus_xmldocs.patch uploaded by Marquis (license 32)
Tested by: otherwiseguy, Marquis