| Summary: | ASTERISK-13099: [patch] update app_readexten to conform to our production version | ||
| Reporter: | David Chappell (chappell) | Labels: | |
| Date Opened: | 2008-11-21 11:30:51.000-0600 | Date Closed: | 2008-11-24 23:19:49.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_readexten |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_readexten.c.patch | |
| Description: | I am the original author of app_readexten. The version that we are running under Asterisk 1.4.X has diverged from the version comited Asterisk 1.6.X. I have merged the two versions and created this patch. ****** ADDITIONAL INFORMATION ****** The changes (relative to the version in SVN) are: * corrected name of copyright holder * corrected return value on syntax error * added code to set return variable to 't' and 'i' in case of timeout and invalid extension (READEXTENSTATUS is still set) * fixed debug code * clarified description The patch is against 1.4.22, but it applies cleanly to 1.6.0.1. | ||
| Comments: | By: David Chappell (chappell) 2008-11-21 12:27:11.000-0600 Forgot to add that this also fixes a bug in which the string of collected digits would not be null terminated. By: Terry Wilson (twilson) 2008-11-24 16:39:40.000-0600 All patches that add features should be against trunk, not 1.6.0, and will be included in a later release when it is branched off. Also, the correct way to do a debug statement in 1.6.0+ is using the ast_debug() macro not checking option_debug directly in the app code--so that part of the patch will need to be fixed as well. By: Tilghman Lesher (tilghman) 2008-11-24 17:29:47.000-0600 Also, applications should return 0, except on hangup. That is the purpose of setting a status variable. By: Digium Subversion (svnbot) 2008-11-24 23:19:49.000-0600 Repository: asterisk Revision: 159054 U trunk/apps/app_readexten.c ------------------------------------------------------------------------ r159054 | tilghman | 2008-11-24 23:19:48 -0600 (Mon, 24 Nov 2008) | 5 lines Copyright clarification; also, have variable set to "t" or "i" on timeout or invalid extension, respectively. (closes issue ASTERISK-13099) Reported by: chappell ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=159054 | ||