Summary:	ASTERISK-13074: [patch] Messages not marked as read/unread properly when moved from New to Old folder and back.
Reporter:	James Rothenberger (jaroth)	Labels:
Date Opened:	2008-11-14 14:27:17.000-0600	Date Closed:	2009-11-23 18:51:19.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail/IMAP
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) foldermove_v2.patch ( 1) foldermove.patch
Description:	This patch fixes a problem with marking of messages in IMAP when they are moved between New and Old folders (this is not really a "move" in IMAP, it is simply an update of the //Seen and //Unseen flags).
Comments:	By: Leif Madsen (lmadsen) 2008-11-19 15:49:25.000-0600 Assigned to Qwell in the hopes he can take a quick look at this. If you are not the appropriate person please re-assign, or un-assign yourself and mark the status as appropriate. Thanks! By: Jason Parker (jparker) 2008-11-19 16:03:08.000-0600 Why is this setting box to NEW_FOLDER?  The following if statement checks for OLD_FOLDER, which after this patch, would never be set. By: James Rothenberger (jaroth) 2008-12-09 15:43:46.000-0600 True.  I'll resubmit without that line in the patch. By: Criss Keating (crissk) 2009-01-12 08:25:44.000-0600 Hi Jim, Any update on this one? Thanks, Criss By: Leif Madsen (lmadsen) 2009-01-12 09:57:58.000-0600 Set status to feedback while waiting for an updated patch from jaroth. By: Leif Madsen (lmadsen) 2009-01-12 09:59:15.000-0600 Ooops... I should have looked to see if there was a submitted patch already. Seems there is a patch here ready for someone to review and/or test. I don't have an IMAP setup here. By: James Golovich (jamesgolovich) 2009-01-21 22:06:55.000-0600 I just tested this out and it is setting the flags appropriately with the patch.  I had to manually apply the patch since the last line was complaining about: patch: **** malformed patch at line 17: but it was simple to do. By: Digium Subversion (svnbot) 2009-02-05 17:29:24.000-0600 Repository: asterisk Revision: 173773 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r173773 | mmichelson | 2009-02-05 17:28:19 -0600 (Thu, 05 Feb 2009) | 7 lines Properly set "seen" and "unseen" flags when moving messages from the new to the old folder when using IMAP for voicemail storage (closes issue ASTERISK-13074) Reported by: jaroth Patches:      foldermove_v2.patch uploaded by jaroth (license 50) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173773 By: Digium Subversion (svnbot) 2009-02-05 17:30:58.000-0600 Repository: asterisk Revision: 173774 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_voicemail.c ------------------------------------------------------------------------ r173774 | mmichelson | 2009-02-05 17:30:58 -0600 (Thu, 05 Feb 2009) | 15 lines Merged revisions 173773 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r173773 | mmichelson | 2009-02-05 17:28:19 -0600 (Thu, 05 Feb 2009) | 7 lines Properly set "seen" and "unseen" flags when moving messages from the new to the old folder when using IMAP for voicemail storage (closes issue ASTERISK-13074) Reported by: jaroth Patches:      foldermove_v2.patch uploaded by jaroth (license 50) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173774 By: Digium Subversion (svnbot) 2009-02-05 17:31:54.000-0600 Repository: asterisk Revision: 173775 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_voicemail.c ------------------------------------------------------------------------ r173775 | mmichelson | 2009-02-05 17:31:54 -0600 (Thu, 05 Feb 2009) | 15 lines Merged revisions 173773 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r173773 | mmichelson | 2009-02-05 17:28:19 -0600 (Thu, 05 Feb 2009) | 7 lines Properly set "seen" and "unseen" flags when moving messages from the new to the old folder when using IMAP for voicemail storage (closes issue ASTERISK-13074) Reported by: jaroth Patches:      foldermove_v2.patch uploaded by jaroth (license 50) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173775