[Home]

Summary:ASTERISK-13065: [patch] Non existent option in the sample configuration file followme.conf (typo)
Reporter:Eliel Sardanons (eliel)Labels:
Date Opened:2008-11-12 19:02:19.000-0600Date Closed:2008-11-25 15:51:18.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Applications/app_followme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) followme.conf.patch
Description:pls_hold_prompt inside a profile is named hold_prompt.
Comments:By: Jason Parker (jparker) 2008-11-18 14:17:13.000-0600

I sort of disagree with this..  Actually, what I disagree with is the option being 'hold-prompt'.  I think this should go the other way, and change the option to be pls-hold-prompt (to match what is done elsewhere).

Thoughts?
By: Mark Michelson (mmichelson) 2008-11-18 18:30:30.000-0600

Whichever way we go on this, the option needs to be consistent between the general and profile usages. It makes no sense to have "pls-hold-prompt" in the general section and just "hold-prompt" within followme profiles.

Right now, I lean towards the "pls-hold-prompt" option. It looks like there was a commit at some point to allow for the prompts specified in a followme profile to have "followme-" prepended or not, and there was a mistake made for this particular option.
By: Leif Madsen (lmadsen) 2008-11-24 16:48:55.000-0600

I'm in agreement with everyone here, especially putnopvut :)
By: Digium Subversion (svnbot) 2008-11-25 15:51:17.000-0600

Repository: asterisk
Revision: 159250

U   trunk/apps/app_followme.c

------------------------------------------------------------------------
r159250 | mmichelson | 2008-11-25 15:49:42 -0600 (Tue, 25 Nov 2008) | 9 lines

Make the options for the general and profiles more consistent
for the "pls_hold_prompt" option. This does not affect any released
version of Asterisk, so there is no need to update the CHANGES
file for this.

(closes issue ASTERISK-13065)
Reported by: eliel


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=159250