[Home]

Summary:ASTERISK-13058: [patch] Problem with timeout in AGI RECORD FILE
Reporter:Andriy I Pylypenko (bamby)Labels:
Date Opened:2008-11-12 06:35:21.000-0600Date Closed:2008-12-11 10:51:23.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_agi.c.patch
Description:When AGI RECORD FILE command is executing but phone becomes dead, then the command hangs forever.

The issue is easily reproducible. For example disconnect SIP phone from the network during record session.

P.S. The Asterisk application Record does not contain this bug.
Comments:By: Joshua C. Colp (jcolp) 2008-12-10 13:24:15.000-0600

This is an issue numerous places in Asterisk which is why there is an rtptimeout option in sip.conf to hang up the channel if RTP has not been received within a specified amount of time. Session timers are also available in the 1.6 series to provide this capability on a signalling level.
By: Andriy I Pylypenko (bamby) 2008-12-11 01:04:11.000-0600

Let me to disagree with your decision.

My point is that the application (AGI RECORD FILE) has a parameter called timeout. And in some circumstances it doesn't execute properly, i.e. doesn't stop when timeout occurs. I'd call such behavior the bug. And bugs should be fixed.

BTW the Record application uses exactly the same logic I've used in my patch.


By: Digium Subversion (svnbot) 2008-12-11 10:51:22.000-0600

Repository: asterisk
Revision: 163088

U   branches/1.4/res/res_agi.c

------------------------------------------------------------------------
r163088 | tilghman | 2008-12-11 10:51:22 -0600 (Thu, 11 Dec 2008) | 6 lines

Don't wait forever, if there's a specified recording timeout.
(closes issue ASTERISK-13058)
Reported by: bamby
Patches:
      res_agi.c.patch uploaded by bamby (license 430)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=163088