[Home]

Summary:ASTERISK-13056: Join event uses CallerID header for caller ID number, when other events now use CallerIDNum
Reporter:David Woolley (davidw)Labels:
Date Opened:2008-11-12 06:23:01.000-0600Date Closed:2008-11-24 18:05:37.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:One of the changes between 1.4 and 1.6 was the use of CallerIDNum as the manager event header for the parsed out caller ID number (cid.cid_num).  However, the Join event, in app_queue, seems to have been missed out and is still using CallerID as the header for this value:



****** ADDITIONAL INFORMATION ******

Current code is

               manager_event(EVENT_FLAG_CALL, "Join",
                       "Channel: %s\r\nCallerID: %s\r\nCallerIDName: %s\r\nQueue: %s\r\nPosition: %d\r\nCount: %d\r\nUniqueid: %s\r\n",
                       qe->chan->name,
                       S_OR(qe->chan->cid.cid_num, "unknown"), /* XXX somewhere else it is <unknown> */
                       S_OR(qe->chan->cid.cid_name, "unknown"),
                       q->name, qe->pos, q->count, qe->chan->uniqueid );

This is the same in the 1.6.0 and 1.6.1 SVN HEAD versions.

These events have been changed to use CallerIDNum:

Newstate
NewCallerID
Dial            
AgentCalled    
Parkedcall        
Unparkedca11
Parkedcalltimeout    
Parkedcallgiveup      
Status                
Queueentry
Comments:By: Leif Madsen (lmadsen) 2008-11-24 14:02:37.000-0600

Issue acknowledged and assigned to mnicholson for review. Please reassign as necessary. Thanks!
By: Digium Subversion (svnbot) 2008-11-24 18:05:37.000-0600

Repository: asterisk
Revision: 158924

U   trunk/UPGRADE.txt
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r158924 | mnicholson | 2008-11-24 18:05:36 -0600 (Mon, 24 Nov 2008) | 6 lines

Make the Join event from app_queue use CallerIDNum insead of CallerID for
indicating the callerid number just like the rest of asterisk.

(closes issue ASTERISK-13056)
Reported by: davidw

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=158924