Summary:	ASTERISK-13050: [patch] Add CLI command 'manager logout <user> [from <ipaddress>]'
Reporter:	Eliel Sardanons (eliel)	Labels:
Date Opened:	2008-11-11 11:50:44.000-0600	Date Closed:	2011-06-07 14:03:00
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) cli_manager_logout.patch ( 1) cli_manager_logout.patch.txt
Description:	Add CLI command 'manager logout <user> from <ipaddress>' as discussed on -dev Please review how I am logging out the user!
Comments:	By: Eliel Sardanons (eliel) 2008-12-04 08:57:58.000-0600 In the last patch I have removed trailing whitespaces and add the changes to the 'CHANGES' file. By: Mark Michelson (mmichelson) 2009-02-02 17:00:02.000-0600 The patch looks good, except that you need to be sure to unlock s->__lock before calling free_session(s) in handle_managerlogout. By: Mark Michelson (mmichelson) 2009-02-02 17:01:28.000-0600 Actually, there's no good reason for me to make you make that change, I'll just do it myself and commit the patch. That will make things easier for everyone. By: Digium Subversion (svnbot) 2009-02-02 17:10:48.000-0600 Repository: asterisk Revision: 173028 U   trunk/CHANGES U   trunk/main/manager.c ------------------------------------------------------------------------ r173028 | mmichelson | 2009-02-02 17:10:48 -0600 (Mon, 02 Feb 2009) | 9 lines Add a CLI command to log out a manager user (closes issue ASTERISK-13050) Reported by: eliel Patches:      cli_manager_logout.patch.txt uploaded by eliel (license 64) Tested by: eliel, putnopvut ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173028 By: Digium Subversion (svnbot) 2009-02-02 17:19:41.000-0600 Repository: asterisk Revision: 173039 _U  branches/1.6.1/ ------------------------------------------------------------------------ r173039 | mmichelson | 2009-02-02 17:19:41 -0600 (Mon, 02 Feb 2009) | 16 lines Blocked revisions 173028 via svnmerge ........ r173028 | mmichelson | 2009-02-02 17:10:47 -0600 (Mon, 02 Feb 2009) | 9 lines Add a CLI command to log out a manager user (closes issue ASTERISK-13050) Reported by: eliel Patches:      cli_manager_logout.patch.txt uploaded by eliel (license 64) Tested by: eliel, putnopvut ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173039 By: Mark Michelson (mmichelson) 2009-02-02 17:20:26.000-0600 Re-opening. I did not know there was a review request open for this at http://reviewboard.digium.com/r/77/ so I did not realize the potential threading issue. By: Tilghman Lesher (tilghman) 2009-02-20 16:23:49.000-0600 eliel:  are you planning on addressing the issues reported here? By: Eliel Sardanons (eliel) 2009-02-20 19:32:37.000-0600 New patch uploaded. By: Matthew Nicholson (mnicholson) 2009-10-20 10:54:32 Reporter plans to redesign this feature.  Please reopen when your redesign is complete.