Summary:ASTERISK-13043: Make clean starts configure in menuselect
Reporter:Olle Johansson (oej)Labels:
Date Opened:2008-11-10 08:36:40.000-0600Date Closed:2009-05-12 19:32:21
Versions:Frequency of
Environment:Attachments:( 0) menuselect_makefile.diff.txt
Description:Running "make clean" starts configure after

rm -f include/asterisk/build.h
rm -f include/asterisk/version.h
make[1]: Entering directory `/usr/local/src/asterisk-'
checking build system type... i686-pc-linux-gnu

Comments:By: Mark Michelson (mmichelson) 2008-11-11 17:09:40.000-0600

I reproduced this, and I traced the problem to the line in menuselect's Makefile that says "-include makeopts" This causes the 'makeopts autoconfig.h" target to be built. The problem is that my Makefile knowledge is very small, so I don't really understand why the -include line would cause that target to be built. I thought -include was used to process another Makefile.

By: Jason Parker (jparker) 2008-11-21 12:51:31.000-0600

From the Asterisk Makefile:

# even though we could use '-include makeopts' here, use a wildcard
# lookup anyway, so that make won't try to build makeopts if it doesn't
# exist (other rules will force it to be built if needed)
ifneq ($(wildcard makeopts),)
 include makeopts

That seems to make sense to do it that way.  Could you try changing the -include line to be the above?

By: Mark Michelson (mmichelson) 2008-11-21 12:53:32.000-0600

qwell: I believe that I tried that already and it did not work correctly. Unfortunately, it's been a while so I don't recall what actually happened when I changed this, but I *think* the result was that the behavior was identical.

By: Terry Wilson (twilson) 2008-12-10 15:34:30.000-0600

Changing the menuselect Makefile like qwell mentioned seems to fix it for my test case, could I get you to try again real quick to see if it fixes for you?  Or at least, if you have a special way that you are reproducing it where this doesn't fix it could you post it and I'll see if there is anything I can do?

EDIT: I posted the patch just for fun

By: Mark Michelson (mmichelson) 2008-12-10 15:46:50.000-0600

Hmm, seems to work fine. I must have messed up some subtlety when I first attempted this fix locally. Commit away, I say!

By: Olle Johansson (oej) 2008-12-10 15:52:49.000-0600

Thanks for spending time on fixing this. I thought it was irritating...

By: Digium Subversion (svnbot) 2008-12-10 15:54:45.000-0600

Repository: menuselect
Revision: 437

U   branches/1.0/Makefile

r437 | twilson | 2008-12-10 15:54:45 -0600 (Wed, 10 Dec 2008) | 8 lines

Make menuselect stop executing configure when running "make clean"

(closes issue ASTERISK-13043)
Reported by: oej
     menuselect_makefile.diff.txt uploaded by otherwiseguy (license 396)
Tested by: putnopvut, otherwiseguy



By: Sean Bright (seanbright) 2009-01-08 15:33:37.000-0600

The fix that when in is causing problems with, at least, 1.4.  Specifically on a fresh checkout of 1.4, running ./configure ; make menuselect was complaining about ncurses not being installed even though it was.  We need another solution.

By: Leif Madsen (lmadsen) 2009-01-09 09:01:35.000-0600

Hmmmmmmmm... I'm not getting that on my system here.

I *was* getting an error before complaining about ncurses not being installed, even though it was, and it ended up being some other package that wasn't related to ncurses at all. Although for the life of me (no pun intended), I can't seem to remember what that package was.

By: Leif Madsen (lmadsen) 2009-05-12 19:32:20

I'm closing this as I don't think it's an issue (or else I'd think we'd have heard about it by now?). If this is still an issue, please open a new issue documenting what the issue is. Thanks!