[Home]

Summary:ASTERISK-13027: Unlimited call for limited calls under 1 seconds (L option)
Reporter:Ruddy G (ruddy)Labels:
Date Opened:2008-11-06 15:42:28.000-0600Date Closed:2008-12-13 17:21:58.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_dial
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Hi.
The issue was regarding the use of the L option to limit the maximum duration of a call.
When we use anything more than 1 second (eg: L(1000)), the feature works ok.
But any value under 1000 ms will result on an unlimited call. (eg: L(900))
In that case, we have the message :
-- Setting call duration limit to 0 seconds.

This seems to be there because in app_dial, we do :
calldurationlimit = timelimit / 1000; --> which give 0 for anything under 1000 ms
and
if (calldurationlimit > 0) {
    peer->whentohangup = time(NULL) + calldurationlimit;
}
So, we never set when to hangup.

My suggestion will then be :
- make sure that we really support durations under 1 second
- make sure that we setup whentohangup field correlty.
Comments:By: Digium Subversion (svnbot) 2008-11-12 15:19:03.000-0600

Repository: asterisk
Revision: 156386

U   branches/1.4/apps/app_dial.c

------------------------------------------------------------------------
r156386 | tilghman | 2008-11-12 15:19:02 -0600 (Wed, 12 Nov 2008) | 5 lines

When using call limits under 1 second, infinite call lengths are allowed,
instead.
(closes issue ASTERISK-13027)
Reported by: ruddy

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=156386
By: Digium Subversion (svnbot) 2008-12-13 17:21:58.000-0600

Repository: asterisk
Revision: 164082

U   branches/1.4/apps/app_dial.c

------------------------------------------------------------------------
r164082 | tilghman | 2008-12-13 17:21:57 -0600 (Sat, 13 Dec 2008) | 9 lines

Change the default calldurationlimit from the special value 0 to -1, so we
can better detect an exceptional case.  This follows on to the changes made
in revision 156386.  Related to issue ASTERISK-13027.
(closes issue ASTERISK-13125)
Reported by: paradise
Patches:
      20081208__bug13974.diff.txt uploaded by Corydon76 (license 14)
Tested by: file, blitzrage, ZX81

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=164082