| Summary: | ASTERISK-13017: The ackcall feature in agent's configurations is misinterpreted | ||
| Reporter: | Corentin Le Gall (clegall_proformatique) | Labels: | |
| Date Opened: | 2008-11-05 10:25:13.000-0600 | Date Closed: | 2008-11-05 10:33:26.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_agent |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Admin problem : While the "ackcall" parameter is never set, the ack seems to be always required. Seen on line 2456 of channels/chan_agent.c : if (strcasecmp(ackcall_s, "always")) instead of if (!strcasecmp(ackcall_s, "always")) or if (strcasecmp(ackcall_s, "always") == 0) which I prefer. ****** ADDITIONAL INFORMATION ****** I went a bit through some might-be other similar cases in asterisk. I did not find anything relevant yet, however, when reading the code, it is not always clear whether the intention was one or the other way (match or not) ... | ||
| Comments: | By: Digium Subversion (svnbot) 2008-11-05 10:33:24.000-0600 Repository: asterisk Revision: 154724 U branches/1.4/channels/chan_agent.c ------------------------------------------------------------------------ r154724 | mmichelson | 2008-11-05 10:33:23 -0600 (Wed, 05 Nov 2008) | 6 lines The logic of a strcasecmp call was reversed (closes issue ASTERISK-13017) Reported by: clegall_proformatique ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=154724 | ||