[Home]

Summary:ASTERISK-13004: [patch] Play a sound to caller when picking up a call
Reporter:Alexander Zielke (azielke)Labels:
Date Opened:2008-11-03 05:01:49.000-0600Date Closed:2009-02-26 12:44:59.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/PBX
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) __20081124_bug_13826_updated.patch
( 1) pickupsound2-trunk.patch
( 2) pickupsound-trunk.diff
Description:Attached is a patch that plays a sound to the caller, when he tried to pick up a call.

****** ADDITIONAL INFORMATION ******

This Patch adds 2 new config parameters (namely "pickupsound" and "pickupfailsound") to features.conf, which default to "".

When they are non-empty, the named file is streamed to the channel, trying the pickup.

This way, the caller has an instant notification, if his pickup worked or not.
Comments:By: Eliel Sardanons (eliel) 2008-11-04 19:15:05.000-0600

always use brackets on if blocks:
if () {
    just one line;
}
instead of:
if ()
     just one line;

also, instead of calling strcpy(something, "");
use something[0] = '\0';
By: Alexander Zielke (azielke) 2008-11-05 10:12:20.000-0600

I uploaded an updated patch that fixes the formatting errors eliel mentioned.


By: Leif Madsen (lmadsen) 2008-11-24 16:31:10.000-0600

Tested successfully!
By: Leif Madsen (lmadsen) 2008-11-24 16:38:55.000-0600

I've also attached an updated patch that applies cleanly to trunk as of today.
By: Digium Subversion (svnbot) 2009-02-26 12:41:29.000-0600

Repository: asterisk
Revision: 178919

U   trunk/CHANGES
U   trunk/configs/features.conf.sample
U   trunk/main/features.c

------------------------------------------------------------------------
r178919 | tilghman | 2009-02-26 12:41:28 -0600 (Thu, 26 Feb 2009) | 8 lines

Sound confirmation of call pickup success.
(closes issue ASTERISK-13004)
Reported by: azielke
Patches:
      pickupsound2-trunk.patch uploaded by azielke (license 548)
      __20081124_bug_13826_updated.patch uploaded by lmadsen (license 10)
Tested by: lmadsen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=178919
By: Digium Subversion (svnbot) 2009-02-26 12:44:56.000-0600

Repository: asterisk
Revision: 178920

_U  branches/1.6.1/

------------------------------------------------------------------------
r178920 | tilghman | 2009-02-26 12:44:55 -0600 (Thu, 26 Feb 2009) | 14 lines

Blocked revisions 178919 via svnmerge

........
 r178919 | tilghman | 2009-02-26 12:41:28 -0600 (Thu, 26 Feb 2009) | 8 lines
 
 Sound confirmation of call pickup success.
 (closes issue ASTERISK-13004)
  Reported by: azielke
  Patches:
        pickupsound2-trunk.patch uploaded by azielke (license 548)
        __20081124_bug_13826_updated.patch uploaded by lmadsen (license 10)
  Tested by: lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=178920