[Home]

Summary:ASTERISK-12970: [patch] mISDN broken for BRI always reporting all chanells in use
Reporter:Igor Goncharovsky (igorg)Labels:
Date Opened:2008-10-27 04:08:56Date Closed:2009-01-19 16:08:24.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_misdn
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) isdn_lib.c.diff
Description:chan_misdn in 1.6.0 broken after beta4 by introducing function test_inuse. In 1.4 this function differ from 1.6.0 and works fine. Ported changes from 1.4
Comments:By: Igor Goncharovsky (igorg) 2008-10-27 04:10:45

Wrong attachment "app_transfer.c.diff" attached, must be deleted. It is for another report.
By: phsultan (phsultan) 2008-11-12 07:54:01.000-0600

Patch tested and validated along with version 1.6.0.1.

Without it, I can't dial out using chan_isdn.
By: Bernhard Wolf (wolfelectronic) 2008-12-02 14:51:48.000-0600

i think this is duplicate with http://bugs.digium.com/view.php?id=13491
By: Igor Goncharovsky (igorg) 2008-12-03 02:33:25.000-0600

Yes, this is duplicate to 13941, but I think that patch from this report should be included because it is just backport from trunk, where no issue exists.
By: Digium Subversion (svnbot) 2009-01-14 13:20:29.000-0600

Repository: asterisk
Revision: 168607

U   branches/1.6.0/channels/misdn/isdn_lib.c

------------------------------------------------------------------------
r168607 | rmudgett | 2009-01-14 13:20:29 -0600 (Wed, 14 Jan 2009) | 9 lines

Fix merge error caused by merging -r132883 and -r121770 from
https://origsvn.digium.com/svn/asterisk/trunk out of order.

(closes issue ASTERISK-12970)
Reported by: IgorG

(closes issue ASTERISK-12737)
Reported by: avalentin

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=168607
By: Igor Goncharovsky (igorg) 2009-01-19 02:55:32.000-0600

r168607 does not fix an issue. Patch is incorrect.
By: Richard Mudgett (rmudgett) 2009-01-19 16:07:11.000-0600

Version 1.6.0 was "broken" because -r121770 had not been merged from trunk.  The patch file attached to this issue contains most of the changes made by -r121770.  However, because -r132883 was merged from trunk in -r132967 before -r121770 was merged from trunk in -r160386 there resulted in the difference fixed by -r168607.

Take your pick: -r160386 or -r168607 closes this issue because the patch file contents are in 1.6.0.