[Home]

Summary:ASTERISK-12948: [patch] Obvious typo (logic error)
Reporter:Matthias Urlichs (smurfix)Labels:
Date Opened:2008-10-21 19:11:25Date Closed:2008-10-22 14:54:37
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dahdi.patch
Description:There's an obvious typo in DAHDI config file processing; see patch.

In addition, a channels= line is currently silently ignored if it's in the wrong section. That's probably not a good idea, debugging-by-reading-source-and-guessing should not be necessary. Also see patch.
Comments:By: Mark Michelson (mmichelson) 2008-10-22 14:51:57

Thanks for the patch! I found another spot in process_dahdi that used a logical and when a bitwise one was appropriate, so I will be committing that change alongside your fix. Thanks!
By: Digium Subversion (svnbot) 2008-10-22 14:54:35

Repository: asterisk
Revision: 151600

U   trunk/channels/chan_dahdi.c

------------------------------------------------------------------------
r151600 | mmichelson | 2008-10-22 14:54:34 -0500 (Wed, 22 Oct 2008) | 10 lines

Change some logical ands to bitwise ands and add
messages alerting that a channel is being ignored
if the PROC_DAHDI_NOCHAN option is set in process_dahdi.

(closes issue ASTERISK-12948)
Reported by: smurfix
Patches:
     dahdi.patch uploaded by smurfix (license 547)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=151600