| Summary: | ASTERISK-12910: [patch] Inband DTMF on outbound call is not detected when dtmfmode=auto | ||
| Reporter: | Makoto Dei (makoto) | Labels: | |
| Date Opened: | 2008-10-16 03:22:29 | Date Closed: | 2009-03-11 11:43:52 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) dtmfmode-auto-outbound-call.patch | |
| Description: | Inband DTMF on outbound call is not detected when dtmfmode=auto because p->vad (DSP for detecting inband DTMF) is not created. On outbound call, p->vad is not created in sip_new(), so should be created in process_sdp() when dtmfmode is switched to inband. I have tested only on 1.2, but I believe that it happens on 1.4 or later. Attached patch will fix the problem. | ||
| Comments: | By: Leif Madsen (lmadsen) 2008-10-16 13:43:49 Would you mind verifying this on 1.4 for us? I will try to test this myself, but not sure when I will have the chance. Thanks! By: Jason Parker (jparker) 2008-11-18 15:07:45.000-0600 Closing due to lack of response. Please reopen once you are able to test on 1.4 or later. By: Makoto Dei (makoto) 2009-02-24 22:55:20.000-0600 Sorry for lack of response. I have tested this issue with 1.6.1-rc1 and reproduced it. How to reproduce 1. Change dtmfmode from inband to auto in sip.conf 2. Call to the phone with Originate then execute VoiceMailMain like this: Action: Originate Channel: SIP/1001 Context: default Exten: 1001 Priority: 1 Timeout: 30000 CallerID: 1001 Application: VoiceMailMain 3. Enter mailbox number, but asterisk doesn't detect DTMF By: Digium Subversion (svnbot) 2009-03-11 11:36:51 Repository: asterisk Revision: 181295 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r181295 | file | 2009-03-11 11:36:50 -0500 (Wed, 11 Mar 2009) | 9 lines Fix a problem with inband DTMF detection on outgoing SIP calls when dtmfmode=auto. When dtmfmode was set to auto the inband DTMF detector was not setup on outgoing SIP calls. This caused inband DTMF detection to fail. The inband DTMF detector is now setup for both dtmfmode inband and auto. ssue ASTERISK-12910) Reported by: makoto ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181295 By: Digium Subversion (svnbot) 2009-03-11 11:37:57 Repository: asterisk Revision: 181295 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r181295 | file | 2009-03-11 11:36:50 -0500 (Wed, 11 Mar 2009) | 9 lines Fix a problem with inband DTMF detection on outgoing SIP calls when dtmfmode=auto. When dtmfmode was set to auto the inband DTMF detector was not setup on outgoing SIP calls. This caused inband DTMF detection to fail. The inband DTMF detector is now setup for both dtmfmode inband and auto. (closes issue ASTERISK-12910) Reported by: makoto ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181295 By: Digium Subversion (svnbot) 2009-03-11 11:40:49 Repository: asterisk Revision: 181296 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r181296 | file | 2009-03-11 11:40:48 -0500 (Wed, 11 Mar 2009) | 16 lines Merged revisions 181295 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r181295 | file | 2009-03-11 13:36:50 -0300 (Wed, 11 Mar 2009) | 9 lines Fix a problem with inband DTMF detection on outgoing SIP calls when dtmfmode=auto. When dtmfmode was set to auto the inband DTMF detector was not setup on outgoing SIP calls. This caused inband DTMF detection to fail. The inband DTMF detector is now setup for both dtmfmode inband and auto. (closes issue ASTERISK-12910) Reported by: makoto ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181296 By: Digium Subversion (svnbot) 2009-03-11 11:42:22 Repository: asterisk Revision: 181297 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r181297 | file | 2009-03-11 11:42:21 -0500 (Wed, 11 Mar 2009) | 23 lines Merged revisions 181296 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r181296 | file | 2009-03-11 13:40:48 -0300 (Wed, 11 Mar 2009) | 16 lines Merged revisions 181295 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r181295 | file | 2009-03-11 13:36:50 -0300 (Wed, 11 Mar 2009) | 9 lines Fix a problem with inband DTMF detection on outgoing SIP calls when dtmfmode=auto. When dtmfmode was set to auto the inband DTMF detector was not setup on outgoing SIP calls. This caused inband DTMF detection to fail. The inband DTMF detector is now setup for both dtmfmode inband and auto. (closes issue ASTERISK-12910) Reported by: makoto ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181297 By: Digium Subversion (svnbot) 2009-03-11 11:43:52 Repository: asterisk Revision: 181298 _U branches/1.6.1/ U branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r181298 | file | 2009-03-11 11:43:51 -0500 (Wed, 11 Mar 2009) | 23 lines Merged revisions 181296 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r181296 | file | 2009-03-11 13:40:48 -0300 (Wed, 11 Mar 2009) | 16 lines Merged revisions 181295 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r181295 | file | 2009-03-11 13:36:50 -0300 (Wed, 11 Mar 2009) | 9 lines Fix a problem with inband DTMF detection on outgoing SIP calls when dtmfmode=auto. When dtmfmode was set to auto the inband DTMF detector was not setup on outgoing SIP calls. This caused inband DTMF detection to fail. The inband DTMF detector is now setup for both dtmfmode inband and auto. (closes issue ASTERISK-12910) Reported by: makoto ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181298 | ||