[Home]

Summary:ASTERISK-12903: [patch] SIP_NOTIFY message incorrectly builds address in the To: tag
Reporter:Andrei Tanas (andrew53)Labels:
Date Opened:2008-10-15 11:13:05Date Closed:2008-10-22 09:57:51
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sip_notify_from_rfc3265.patch
Description:Result of strncasecmp is misinterpreted, which results in either forming address with no "sip:" prefix, or with the prefix repeated.

If the SUBSCRIBE From: tag was user@domain, it will result in
To: <user@domain....
If the SUBSCRIBE From: tag was sip:user@domain, it will result in
To: <sip:sip:user@domain...
Comments:By: Leif Madsen (lmadsen) 2008-10-15 11:17:35

Thanks for the patch! Hopefully it can get looked at shortly!
By: Leif Madsen (lmadsen) 2008-10-15 11:18:13

I assigned this to putnopvut in the hopes he can take a quick look at it and merge if appropriate. Feel free to re-assign if necessary.
By: Mark Michelson (mmichelson) 2008-10-22 09:46:36

Yes, the logic is definitely backwards on that, and this patch corrects it. Thank you for the contribution and I'll get this fix in as soon as possible.
By: Digium Subversion (svnbot) 2008-10-22 09:57:49

Repository: asterisk
Revision: 151512

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r151512 | mmichelson | 2008-10-22 09:57:48 -0500 (Wed, 22 Oct 2008) | 8 lines

The logic of a strncasecmp call was reversed.

(closes issue ASTERISK-12903)
Reported by: andrew53
Patches:
     sip_notify_from_rfc3265.patch uploaded by andrew53 (license 519)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=151512