[Home]

Summary:ASTERISK-12894: [patch] Comply with trunk coding guidlines
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2008-10-15 02:41:17Date Closed:2008-10-16 17:25:35
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Applications/app_skel
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_skel.bug13696B.115850.diff.txt
Description:Add braces to all IF structures
Comments:By: Alec Davis (alecdavis) 2008-10-15 02:56:01

SVN number is wrong should be 115850

uploaded patch app_skel.bug13696.115850.diff.txt
By: snuffy (snuffy) 2008-10-15 03:24:14

The updated coding guidelines in trunk were more intended for any new code to be accepted into asterisk.

app_skel having the correct if formatting could be useful though.
By: Alec Davis (alecdavis) 2008-10-15 04:58:33

So, patches should be of the same coding style as the existing code?

I'll leave app_voicemail alone then :)
By: Alec Davis (alecdavis) 2008-10-15 05:14:57

Please delete app_skel.bug13696.115850.diff.txt patch finished up with } on end of line

Uploaded correct app_skel.bug13696B.115850.diff.txt
By: Mark Michelson (mmichelson) 2008-10-16 17:24:08

Yeah, snuffy is right in the sense that the coding guidelines change was mostly intended as a guideline for new development, but if we're being offered patches which update the coding guidelines to match the current style, I see no problem with that at all. I'll go ahead and get this committed.
By: Digium Subversion (svnbot) 2008-10-16 17:25:33

Repository: asterisk
Revision: 150255

U   trunk/apps/app_skel.c

------------------------------------------------------------------------
r150255 | mmichelson | 2008-10-16 17:25:33 -0500 (Thu, 16 Oct 2008) | 9 lines

Updating app_skel.c to follow coding guidelines
with regards to braces used on if statements.

(closes issue ASTERISK-12894)
Reported by: alecdavis
Patches:
     app_skel.bug13696B.115850.diff.txt uploaded by alecdavis (license 585)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=150255