Summary:ASTERISK-12829: [patch] CANCEL before Trying
Reporter:Atis Lezdins (atis)Labels:
Date Opened:2008-10-06 10:16:33Date Closed:2010-04-30 13:35:14
Versions:Frequency of
Environment:Attachments:( 0) 13626.patch
( 1) dial_0_timeout.log
Description:If executing Dial with timeout 0, it places a call and then CANCEL is sent immediately before receiving TRYING message.

Related to ASTERISK-12828
Asterisk 1.6.0
Comments:By: Leif Madsen (lmadsen) 2008-10-14 11:43:38

Assigning this issue to file as well since it is related to another similar issue, and perhaps they can be resolved together? Please reassign if necessary. Same issue as mentioned in the other bug note about file being extremely busy recently applies.

By: Mark Michelson (mmichelson) 2008-10-15 16:16:10

I've uploaded a patch that corrects the issue for me. Please test to see if this works for you as well.

By: Mark Michelson (mmichelson) 2008-10-16 16:32:03

Changing the status to "ready for testing" since there is a patch which needs testing.

By: Leif Madsen (lmadsen) 2008-10-21 14:02:16

atis: any chance of getting this patch tested?

By: Atis Lezdins (atis) 2008-10-21 14:55:28

Sorry for delay, i'm quite busy currently, but will try to test it this week.

By: Atis Lezdins (atis) 2008-10-22 08:51:39

This seems to fix issue, we have also tested several other scenarios, and everything seems fine.

blitzrage, i wonder why have you changed version to 1.6.1-beta1. Issue was found in 1.6.0 but there was no such version in mantis yet. Is this expected to be included in 1.6.1?

By: Leif Madsen (lmadsen) 2008-10-22 10:08:00

Hrmmm... I don't actually remember changing this, but it appears I did. I wonder if that was done automatically after I modified some tags for mantis. I'll be sure to switch this back to 1.6.0 for you.

Thanks for testing atis and reporting back!

By: Leif Madsen (lmadsen) 2008-10-22 10:09:05

It is possible this may make it into 1.6.1 as this appears to be a bug. It will be up to the developer who merges this to determine where to merge, but I suspect this will be in 1.6.1.

By: Leif Madsen (lmadsen) 2008-10-27 12:11:13

I said I wouldn't assign anymore to putnopvut, but since this one is tested and seems to fix the issue, I'm hoping he can take this "one last issue(tm)" and get it committed :)

By: Atis Lezdins (atis) 2008-11-07 07:44:18.000-0600

I think that it would be good that either this issue or ASTERISK-12828 is fixed in 1.6.0.

Currently if you would try Dial with timeout 0, our Linksys PAP2  would just ring and ring without ever stopping. Picking up hook would just give you dialtone.

By: Mark Michelson (mmichelson) 2008-11-07 17:41:18.000-0600

Ah, sorry. I must have missed the note where you mentioned that the patch fixed your problem, otherwise I would have merged this back then. It's going in now, though :), and I'll go ahead and put it in 1.6.0, too.

By: Digium Subversion (svnbot) 2008-11-07 17:41:39.000-0600

Repository: asterisk
Revision: 155467

U   trunk/channels/chan_sip.c

r155467 | mmichelson | 2008-11-07 17:41:39 -0600 (Fri, 07 Nov 2008) | 12 lines

Set the invite state to INV_CANCELLED in a place that
makes more sense. Where it was set before, it was impossible
to actually delay sending a CANCEL if we had not yet received
a provisional response to an INVITE.

(closes issue ASTERISK-12829)
Reported by: atis
     13626.patch uploaded by putnopvut (license 60)
Tested by: atis