|Summary:||ASTERISK-12820: no warning message returned when soxmix is not installed|
|Reporter:||Giorgio Incantalupo (gincantalupo)||Labels:|
|Date Opened:||2008-10-03 07:40:57||Date Closed:||2011-06-07 14:10:23|
|Description:||ast_safe_system() in ast_monitor_stop function does not return -1 if soxmix is not installed, so no warning message is shown (0 is returned instead).|
Not tried with sox.
Asterisk version is 1.4.22 rc5
|Comments:||By: Michiel van Baak (mvanbaak) 2008-10-04 06:40:13|
Do you have sox installed ?
the configure script will look for soxmix so if it's not there it's using 'sox -m'
By: Giorgio Incantalupo (gincantalupo) 2008-10-06 05:12:10
Ok..I only wanted to point out that if sox (or soxmix) is not installed (for some reason) I get no warning as I expect from the check:
if (ast_safe_system(tmp) == -1)
ast_log(LOG_WARNING, "Execute of %s failed.\n",tmp);
But it is not important. Close this issue, please.
By: Sean Bright (seanbright) 2008-10-06 07:42:55
The check for sox in the configure script is flawed, as are the conditionals in res_monitor. While in most cases the build system and target system are the same, sometimes they are not. So finding sox or soxmix at configure time is relatively meaningless. I'm going to leave this open for now and assign it to myself and see if I can't come up with a workable solution. Any change to 1.4 at this point will only address the return value passed back from ast_safe_system. Hopefully we can have a more elegant solution in trunk/1.6.2.
By: Tilghman Lesher (tilghman) 2008-11-04 15:56:27.000-0600
Can this be added to a personal TODO list so as not to leave this issue hanging open?
By: Sean Bright (seanbright) 2008-12-10 10:02:36.000-0600
As suggested by Tilghman, putting this on my radar but taking it off the bug tracker.