[Home]

Summary:ASTERISK-12816: [patch] Compile error with IMAP_STORAGE due to removed autoconfig.h in Makefile
Reporter:Tomo Takebe (tomo1657)Labels:
Date Opened:2008-10-02 15:56:13Date Closed:2008-10-09 19:31:59
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail/IMAP
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 13605_seanbright.diff
( 1) imap_include_autoconf.patch
Description:The removal of autoconfig.h in the Makefile at revision 144993 prevents app_voicemail.c from compiling with the IMAP_STORAGE flag.

Optimally we would want to #include "asterisk.h" before the IMAP includes, but as the comments show, this creates other compile issues involving the logger.

The quick solution seems to be to keep "asterisk.h" after the IMAP includes, but additionally include "asterisk/autoconfig.h above the other includes when IMAP_STORAGE flag is enabled.

#ifdef IMAP_STORAGE
#include "asterisk/autoconfig.h"    // <-- include autoconfig.h line ASTERISK-68
#include <ctype.h>
#include <signal.h>
...

I've attached a patch for this but there may be a more elegant solution.

****** STEPS TO REPRODUCE ******

compile 1.6.1 revision 144993 or greater with IMAP_STORAGE
Comments:By: Sean Bright (seanbright) 2008-10-05 06:17:48

I am trying to determine if there is a cleaner fix, but your patch does clear up the compile problems others are having as well.
By: Digium Subversion (svnbot) 2008-10-09 19:31:56

Repository: asterisk
Revision: 148200

U   trunk/apps/app_voicemail.c
U   trunk/include/asterisk.h
U   trunk/main/cryptostub.c
U   trunk/main/tdd.c
U   trunk/res/res_config_sqlite.c

------------------------------------------------------------------------
r148200 | seanbright | 2008-10-09 19:31:55 -0500 (Thu, 09 Oct 2008) | 12 lines

Don't include logger.h in asterisk.h by default as it is causing problems building
app_voicemail.  Instead, include it where it is needed.  This turned out to be a
relatively minor issue because other headers include logger.h as well.

Need to test -addons before merging this back to 1.6.0.

(closes issue ASTERISK-12816)
Reported by: tomo1657
Patches:
     13605_seanbright.diff uploaded by seanbright (license 71)
Tested by: mmichelson

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=148200