[Home]

Summary:ASTERISK-12808: clid will only set number not name
Reporter:John Hass (john8675309)Labels:
Date Opened:2008-10-01 20:56:38Date Closed:2008-12-03 14:41:39.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:CDR/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch.13597
Description:After upgrading to 1.4 svn CLID will no long hold the name and the number just the number.  Here is my dialplan.

exten => 7124320002,1,answer
exten => 7124320002,2,set(CALLERID(all)="John" <999>)
exten => 7124320002,3,wait(7200)

core show channels information
 CDR Variables:
level 1: clid=999
level 1: src=999
level 1: dst=700
level 1: dcontext=default
level 1: channel=SIP/192.168.1.1-007a59d0
level 1: lastapp=Wait
level 1: lastdata=7200
level 1: start=2008-10-01 21:04:36
level 1: answer=2008-10-01 21:04:36
level 1: duration=0
level 1: billsec=0
level 1: disposition=ANSWERED
level 1: amaflags=DOCUMENTATION
level 1: uniqueid=1222913076.8

this worked in 1.4.21 just fine
Comments:By: Sean Bright (seanbright) 2008-10-06 08:59:46

I can confirm that the behavior changed between 1.4.21 and 1.4.22 (tested on both tags).  I took a look at the diff between the two and nothing jumped out.  I'm available to test more if necessary.
By: Steve Murphy (murf) 2008-10-08 15:48:31

OK, took some time and researched this. The cause is when I introduced the CDR4/5/6 changes into 1.4, in svn ver 127663, I removed a call to ast_cdr_setcid() from ast_set_callerid().

Normally, one would think that having ast_set_callerid also set the cdr's CID info would be an excellent idea. But, ast_set_callerid is called from a lot of places at a lot of different times, and it made xfers work better to remove it.

So, the fix will most likely be moving the call to set the CDR info to more
specific places, like in func_callerid itself. I'll test this theory out.
By: Steve Murphy (murf) 2008-11-11 14:06:07.000-0600

I've just attached a patch to this bug: patch.13597; if you could,
could you apply it to your src and see if it gives you the results
you seek?
By: Steve Murphy (murf) 2008-12-01 15:42:24.000-0600

Hmmm, any updates? Have you tried this? did it help?

By: John Hass (john8675309) 2008-12-03 09:13:23.000-0600

Sorry this took me so long to get back to you.  It works well now!
By: Digium Subversion (svnbot) 2008-12-03 14:41:38.000-0600

Repository: asterisk
Revision: 160703

U   branches/1.4/funcs/func_callerid.c

------------------------------------------------------------------------
r160703 | murf | 2008-12-03 14:41:37 -0600 (Wed, 03 Dec 2008) | 11 lines

(closes issue ASTERISK-12808)
Reported by: john8675309
Patches:
     patch.13597 uploaded by murf (license 17)
Tested by: murf, john8675309

This patch causes the setcid func to update the CDR
clid after setting the channel field.



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=160703