| Summary: | ASTERISK-12740: One-touch parking failure results in the call drop, while parties should be able to continue conversation | ||
| Reporter: | mdu113 (mdu113) | Labels: | |
| Date Opened: | 2008-09-16 11:45:03 | Date Closed: | 2009-02-04 17:38:59.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Resources/res_features |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | I believe that in case of one-touch parking, a parking failure should not cause the call to be dropped. Scenario: A calls B, B answers and attempts to park A. If the parking fails for any reason (requested parking extension is busy or all parking spaces are already in use) then asterisk now drops the call, while I believe the parties should be able to continue conversation and possibly make another parking attempt later. | ||
| Comments: | By: Jeff Peeler (jpeeler) 2008-09-16 11:57:12 Thanks for following up on this as request. I've modified the report a bit though because this issue is totally independent of bug 13425. Remember that this behavior was present before any changes for 13425 were made. By: mdu113 (mdu113) 2008-09-16 12:17:17 Sure. I just meant to say then it was first discussed in that issue. By: Jeff Peeler (jpeeler) 2008-12-09 10:56:12.000-0600 This is not related to 13425. By: Jeff Peeler (jpeeler) 2009-01-22 17:12:31.000-0600 Upon further investigation I'm not sure this can be categorized as a bug as there is already a distinct different behavior defined. In the case of the caller attempting unsuccessfully to do a one touch park the peer is hung up, but further dialplan execution is attempted for the caller. By: Jeff Peeler (jpeeler) 2009-01-23 10:24:49.000-0600 After discussing this the current defined behavior is unexpected so I'm going to start working on this. By: Jeff Peeler (jpeeler) 2009-01-26 17:02:42.000-0600 This code is being reviewed on review board, but is also available in a branch: http://svn.digium.com/svn/asterisk/team/jpeeler/bug13494 By: Digium Subversion (svnbot) 2009-02-03 15:57:02.000-0600 Repository: asterisk Revision: 173211 U branches/1.4/res/res_features.c ------------------------------------------------------------------------ r173211 | jpeeler | 2009-02-03 15:57:01 -0600 (Tue, 03 Feb 2009) | 17 lines Parking attempts made to one end of a bridge no longer will hang up due to a parking failure. Parking attempts made using either one-touch, or doing either a blind or assisted transfer to the parking extension now keep up the bridge instead of hanging up the attempted parked party. Normal causes for the parking attempt to fail includes the specific specified extension (via PARKINGEXTEN) not being available or if all the parking spaces are currently in use. To avoid having to reverse a masquerade park_space_reserve was made to provide foresight if a parking attempt will succeed and if so reserve the parking space. (closes issue ASTERISK-12740) Reported by: mdu113 Reviewed by Russell: http://reviewboard.digium.com/r/133/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173211 By: Digium Subversion (svnbot) 2009-02-04 15:17:55.000-0600 Repository: asterisk Revision: 173500 _U trunk/ U trunk/include/asterisk/features.h U trunk/main/features.c ------------------------------------------------------------------------ r173500 | jpeeler | 2009-02-04 15:17:55 -0600 (Wed, 04 Feb 2009) | 23 lines Merged revisions 173211 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173211 | jpeeler | 2009-02-03 15:57:01 -0600 (Tue, 03 Feb 2009) | 17 lines Parking attempts made to one end of a bridge no longer will hang up due to a parking failure. Parking attempts made using either one-touch, or doing either a blind or assisted transfer to the parking extension now keep up the bridge instead of hanging up the attempted parked party. Normal causes for the parking attempt to fail includes the specific specified extension (via PARKINGEXTEN) not being available or if all the parking spaces are currently in use. To avoid having to reverse a masquerade park_space_reserve was made to provide foresight if a parking attempt will succeed and if so reserve the parking space. (closes issue ASTERISK-12740) Reported by: mdu113 Reviewed by Russell: http://reviewboard.digium.com/r/133/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173500 By: Digium Subversion (svnbot) 2009-02-04 15:28:57.000-0600 Repository: asterisk Revision: 173505 _U branches/1.6.1/ U branches/1.6.1/include/asterisk/features.h U branches/1.6.1/main/features.c ------------------------------------------------------------------------ r173505 | jpeeler | 2009-02-04 15:28:57 -0600 (Wed, 04 Feb 2009) | 30 lines Merged revisions 173500 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r173500 | jpeeler | 2009-02-04 15:17:53 -0600 (Wed, 04 Feb 2009) | 23 lines Merged revisions 173211 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173211 | jpeeler | 2009-02-03 15:57:01 -0600 (Tue, 03 Feb 2009) | 17 lines Parking attempts made to one end of a bridge no longer will hang up due to a parking failure. Parking attempts made using either one-touch, or doing either a blind or assisted transfer to the parking extension now keep up the bridge instead of hanging up the attempted parked party. Normal causes for the parking attempt to fail includes the specific specified extension (via PARKINGEXTEN) not being available or if all the parking spaces are currently in use. To avoid having to reverse a masquerade park_space_reserve was made to provide foresight if a parking attempt will succeed and if so reserve the parking space. (closes issue ASTERISK-12740) Reported by: mdu113 Reviewed by Russell: http://reviewboard.digium.com/r/133/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173505 By: Digium Subversion (svnbot) 2009-02-04 17:38:59.000-0600 Repository: asterisk Revision: 173546 U branches/1.6.0/main/features.c ------------------------------------------------------------------------ r173546 | jpeeler | 2009-02-04 17:38:59 -0600 (Wed, 04 Feb 2009) | 30 lines Merged revisions 173500 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r173500 | jpeeler | 2009-02-04 15:17:53 -0600 (Wed, 04 Feb 2009) | 23 lines Merged revisions 173211 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173211 | jpeeler | 2009-02-03 15:57:01 -0600 (Tue, 03 Feb 2009) | 17 lines Parking attempts made to one end of a bridge no longer will hang up due to a parking failure. Parking attempts made using either one-touch, or doing either a blind or assisted transfer to the parking extension now keep up the bridge instead of hanging up the attempted parked party. Normal causes for the parking attempt to fail includes the specific specified extension (via PARKINGEXTEN) not being available or if all the parking spaces are currently in use. To avoid having to reverse a masquerade park_space_reserve was made to provide foresight if a parking attempt will succeed and if so reserve the parking space. (closes issue ASTERISK-12740) Reported by: mdu113 Reviewed by Russell: http://reviewboard.digium.com/r/133/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=173546 | ||