| Summary: | ASTERISK-12703: [patch] Audible clicks when playing a file with header larger than AU_HEADER_SIZE | ||||
| Reporter: | James McCoy (jamessan) | Labels: | |||
| Date Opened: | 2008-09-09 13:11:38 | Date Closed: | 2008-09-22 17:39:09 | ||
| Priority: | Minor | Regression? | No | ||
| Status: | Closed/Complete | Components: | Formats/format_pcm | ||
| Versions: | Frequency of Occurrence | ||||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) pcm-header.diff | |||
| Description: | format_pcm.c:check_header ignores the defined header size in the file and instead simply expects the header to be AU_HEADER_SIZE bytes long. If the headers are actually longer than that, this causes the audio to "click" since the rest of the headers are played as part of the file. I ran across this as sox adds it's own "Processed by SoX" comment to the header when it transcodes files. | ||||
| Comments: | By: Leif Madsen (lmadsen) 2008-09-10 08:39:57 Patch attached requires code review by a developer. Thanks! By: Digium Subversion (svnbot) 2008-09-22 17:39:06 Repository: asterisk Revision: 143903 U branches/1.4/formats/format_pcm.c ------------------------------------------------------------------------ r143903 | seanbright | 2008-09-22 17:39:06 -0500 (Mon, 22 Sep 2008) | 8 lines Use the advertised header size in .au files instead of just assuming they are 24 bytes (the minimum). (closes issue ASTERISK-12703) Reported by: jamessan Patches: pcm-header.diff uploaded by jamessan (license 246) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=143903 | ||||